mirror of
https://github.com/discourse/discourse.git
synced 2024-11-24 03:42:16 +08:00
0d809197aa
When copying an existing upload stub temporary object on S3 to its final destination we were not copying across its additional headers such as content-disposition and cache-control, which led to issues like attachments not downloading with their original filename when clicking the download links in posts. This is because the metadata_directive = REPLACE option was not being passed to object.copy_from(), so only the source object's headers were being used. Added an option for apply_metadata_to_destination to apply this option conditionally, because we may not always want to replace this metadata, but we definitely do when copying a temporary upload. |
||
---|---|---|
.. | ||
base_store_spec.rb | ||
local_store_spec.rb | ||
s3_store_spec.rb |