mirror of
https://github.com/discourse/discourse.git
synced 2024-11-30 23:23:58 +08:00
454a4af0bf
Why this change? By ensuring the reset happens in an `ensure` code block, we ensure that the code will always be run even if code fails or an error is raised. This helps to prevent leaking custom network condition states and improves the stability of our system tests.
150 lines
4.6 KiB
Ruby
150 lines
4.6 KiB
Ruby
# frozen_string_literal: true
|
||
|
||
RSpec.describe "Chat composer", type: :system do
|
||
fab!(:current_user) { Fabricate(:user) }
|
||
fab!(:channel_1) { Fabricate(:chat_channel) }
|
||
fab!(:message_1) { Fabricate(:chat_message, user: current_user, chat_channel: channel_1) }
|
||
|
||
let(:chat_page) { PageObjects::Pages::Chat.new }
|
||
let(:channel_page) { PageObjects::Pages::ChatChannel.new }
|
||
|
||
before do
|
||
chat_system_bootstrap
|
||
channel_1.add(current_user)
|
||
sign_in(current_user)
|
||
end
|
||
|
||
context "when adding an emoji through the picker" do
|
||
xit "adds the emoji to the composer" do
|
||
chat_page.visit_channel(channel_1)
|
||
channel_page.open_action_menu
|
||
channel_page.click_action_button("emoji")
|
||
find("[data-emoji='grimacing']").click(wait: 0.5)
|
||
|
||
expect(channel_page.composer.value).to eq(":grimacing:")
|
||
end
|
||
|
||
it "removes denied emojis from insert emoji picker" do
|
||
SiteSetting.emoji_deny_list = "monkey|peach"
|
||
|
||
chat_page.visit_channel(channel_1)
|
||
channel_page.composer.open_emoji_picker
|
||
|
||
expect(page).to have_no_selector("[data-emoji='monkey']")
|
||
expect(page).to have_no_selector("[data-emoji='peach']")
|
||
end
|
||
end
|
||
|
||
context "when adding an emoji through the autocomplete" do
|
||
it "adds the emoji to the composer" do
|
||
chat_page.visit_channel(channel_1)
|
||
find(".chat-composer__input").fill_in(with: ":gri")
|
||
find(".emoji-shortname", text: "grimacing").click
|
||
|
||
expect(channel_page.composer.value).to eq(":grimacing: ")
|
||
end
|
||
|
||
it "doesn't suggest denied emojis and aliases" do
|
||
SiteSetting.emoji_deny_list = "peach|poop"
|
||
chat_page.visit_channel(channel_1)
|
||
|
||
find(".chat-composer__input").fill_in(with: ":peac")
|
||
expect(page).to have_no_selector(".emoji-shortname", text: "peach")
|
||
|
||
find(".chat-composer__input").fill_in(with: ":hank") # alias
|
||
expect(page).to have_no_selector(".emoji-shortname", text: "poop")
|
||
end
|
||
end
|
||
|
||
context "when opening emoji picker through more button of the autocomplete" do
|
||
xit "prefills the emoji picker filter input" do
|
||
chat_page.visit_channel(channel_1)
|
||
find(".chat-composer__input").fill_in(with: ":gri")
|
||
|
||
click_link(I18n.t("js.composer.more_emoji"))
|
||
|
||
expect(find(".chat-emoji-picker .dc-filter-input").value).to eq("gri")
|
||
end
|
||
|
||
xit "filters with the prefilled input" do
|
||
chat_page.visit_channel(channel_1)
|
||
find(".chat-composer__input").fill_in(with: ":fr")
|
||
|
||
click_link(I18n.t("js.composer.more_emoji"))
|
||
|
||
expect(page).to have_selector(".chat-emoji-picker [data-emoji='fr']")
|
||
expect(page).to have_no_selector(".chat-emoji-picker [data-emoji='grinning']")
|
||
end
|
||
end
|
||
|
||
context "when typing on keyboard" do
|
||
it "propagates keys to composer" do
|
||
chat_page.visit_channel(channel_1)
|
||
|
||
find("body").send_keys("b")
|
||
|
||
expect(channel_page.composer.value).to eq("b")
|
||
|
||
find("body").send_keys("b")
|
||
|
||
expect(channel_page.composer.value).to eq("bb")
|
||
|
||
find("body").send_keys(:enter) # special case
|
||
|
||
expect(channel_page.composer.value).to eq("bb")
|
||
end
|
||
end
|
||
|
||
context "when editing a message with no length" do
|
||
it "deletes the message" do
|
||
chat_page.visit_channel(channel_1)
|
||
channel_page.composer.edit_last_message_shortcut
|
||
channel_page.composer.fill_in(with: "")
|
||
channel_page.click_send_message
|
||
|
||
expect(channel_page.messages).to have_message(deleted: 1)
|
||
end
|
||
end
|
||
|
||
context "when posting a message with length equal to minimum length" do
|
||
before { SiteSetting.chat_minimum_message_length = 1 }
|
||
|
||
it "works" do
|
||
chat_page.visit_channel(channel_1)
|
||
channel_page.send_message("1")
|
||
|
||
expect(channel_page.messages).to have_message(text: "1")
|
||
end
|
||
end
|
||
|
||
context "when posting a message with length superior to minimum length" do
|
||
before { SiteSetting.chat_minimum_message_length = 2 }
|
||
|
||
it "doesn’t allow to send" do
|
||
chat_page.visit_channel(channel_1)
|
||
find("body").send_keys("1")
|
||
|
||
expect(page).to have_css(".chat-composer.is-send-disabled")
|
||
end
|
||
end
|
||
|
||
context "when upload is in progress" do
|
||
it "doesn’t allow to send" do
|
||
chat_page.visit_channel(channel_1)
|
||
|
||
page.driver.browser.network_conditions = { latency: 20_000 }
|
||
|
||
file_path = file_from_fixtures("logo.png", "images").path
|
||
attach_file(file_path) do
|
||
channel_page.open_action_menu
|
||
channel_page.click_action_button("chat-upload-btn")
|
||
end
|
||
|
||
expect(page).to have_css(".chat-composer-upload--in-progress")
|
||
expect(page).to have_css(".chat-composer.is-send-disabled")
|
||
ensure
|
||
page.driver.browser.network_conditions = { latency: 0 }
|
||
end
|
||
end
|
||
end
|