discourse/test
Robin Ward f9608c0af5 DEV: Remove INLINE_ONEBOX_* constants
There were two constants here, `INLINE_ONEBOX_LOADING_CSS_CLASS` and
`INLINE_ONEBOX_CSS_CLASS` that were both longer than the strings they
were DRYing up: `inline-onebox-loading` and `inline-onebox`

I normally appreciate constants, but in this case it meant that we had
a lot of JS imports resulting in many more lines of code (and CPU cycles
spent figuring them out.)

It also meant we had an `.erb` file and had to invoke Ruby to create the
JS file, which meant the app was harder to port to Ember CLI.

I removed the constants. It's less DRY but faster and simpler, and
arguably the loss of DRYness is not significant as you can still search
for the `inline-onebox-loading` and `inline-onebox` strings easily if
you are refactoring.
2020-05-07 16:14:38 -04:00
..
javascripts DEV: Remove INLINE_ONEBOX_* constants 2020-05-07 16:14:38 -04:00
stylesheets Manage qunit via yarn. 2018-09-11 15:07:28 +08:00
run-qunit.js DEV: use REPORT_REQUESTS=1 to find all requests 2020-04-02 16:01:49 +11:00
smoke_test.js DEV: Use classes for styling user and group cards (#8913) 2020-02-13 09:58:17 +00:00