mirror of
https://github.com/discourse/discourse.git
synced 2024-11-30 09:03:45 +08:00
6e161d3e75
The most common thing that we do with fab! is:
fab!(:thing) { Fabricate(:thing) }
This commit adds a shorthand for this which is just simply:
fab!(:thing)
i.e. If you omit the block, then, by default, you'll get a `Fabricate`d object using the fabricator of the same name.
116 lines
3.6 KiB
Ruby
116 lines
3.6 KiB
Ruby
# frozen_string_literal: true
|
|
RSpec.describe "Topic Thumbnails" do
|
|
before do
|
|
SiteSetting.create_thumbnails = true
|
|
ImageSizer.stubs(:resize).returns([9, 9])
|
|
end
|
|
|
|
fab!(:image) { Fabricate(:image_upload, width: 50, height: 50) }
|
|
fab!(:topic) { Fabricate(:topic, image_upload_id: image.id) }
|
|
fab!(:user)
|
|
|
|
describe "latest" do
|
|
def get_topic
|
|
Discourse.redis.del(topic.thumbnail_job_redis_key(Topic.thumbnail_sizes))
|
|
Discourse.redis.del(topic.thumbnail_job_redis_key([]))
|
|
get "/latest.json"
|
|
expect(response.status).to eq(200)
|
|
response.parsed_body["topic_list"]["topics"][0]
|
|
end
|
|
|
|
it "does not include thumbnails by default" do
|
|
topic_json = get_topic
|
|
|
|
expect(topic_json["thumbnails"]).to eq(nil)
|
|
end
|
|
|
|
context "with a theme" do
|
|
before do
|
|
theme = Fabricate(:theme)
|
|
theme.theme_modifier_set.topic_thumbnail_sizes = [[10, 10], [20, 20], [30, 30]]
|
|
theme.theme_modifier_set.save!
|
|
theme.set_default!
|
|
end
|
|
|
|
it "includes the theme specified resolutions" do
|
|
topic_json = nil
|
|
|
|
expect do topic_json = get_topic end.to change {
|
|
Jobs::GenerateTopicThumbnails.jobs.size
|
|
}.by(2)
|
|
|
|
expect(Jobs::GenerateTopicThumbnails.jobs.map { |j| j["args"][0]["extra_sizes"] }).to eq(
|
|
[
|
|
nil, # Job for core/plugin sizes
|
|
[[10, 10], [20, 20], [30, 30]],
|
|
], # Job for theme sizes
|
|
)
|
|
|
|
thumbnails = topic_json["thumbnails"]
|
|
|
|
# Original only. Optimized not yet generated
|
|
expect(thumbnails.length).to eq(1)
|
|
|
|
# Original
|
|
expect(thumbnails[0]["max_width"]).to eq(nil)
|
|
expect(thumbnails[0]["max_height"]).to eq(nil)
|
|
expect(thumbnails[0]["width"]).to eq(image.width)
|
|
expect(thumbnails[0]["height"]).to eq(image.height)
|
|
expect(thumbnails[0]["url"]).to end_with(image.url)
|
|
|
|
# Run the job
|
|
args = Jobs::GenerateTopicThumbnails.jobs.last["args"].first
|
|
Jobs::GenerateTopicThumbnails.new.execute(args.with_indifferent_access)
|
|
|
|
# Request again
|
|
expect do topic_json = get_topic end.not_to change {
|
|
Jobs::GenerateTopicThumbnails.jobs.size
|
|
}
|
|
|
|
thumbnails = topic_json["thumbnails"]
|
|
|
|
# Original + Optimized + 3 theme requests
|
|
expect(thumbnails.length).to eq(5)
|
|
|
|
# Check first optimized
|
|
expect(thumbnails[1]["max_width"]).to eq(Topic.share_thumbnail_size[0])
|
|
expect(thumbnails[1]["max_height"]).to eq(Topic.share_thumbnail_size[1])
|
|
expect(thumbnails[1]["width"]).to eq(9)
|
|
expect(thumbnails[1]["height"]).to eq(9)
|
|
expect(thumbnails[1]["url"]).to include("/optimized/")
|
|
end
|
|
end
|
|
|
|
context "with a plugin" do
|
|
before do
|
|
plugin = Plugin::Instance.new
|
|
plugin.register_topic_thumbnail_size [512, 512]
|
|
end
|
|
|
|
after { DiscoursePluginRegistry.reset! }
|
|
|
|
it "includes the theme specified resolutions" do
|
|
topic_json = nil
|
|
|
|
expect do topic_json = get_topic end.to change {
|
|
Jobs::GenerateTopicThumbnails.jobs.size
|
|
}.by(1)
|
|
|
|
# Run the job
|
|
args = Jobs::GenerateTopicThumbnails.jobs.last["args"].first
|
|
Jobs::GenerateTopicThumbnails.new.execute(args.with_indifferent_access)
|
|
|
|
# Request again
|
|
expect do topic_json = get_topic end.not_to change {
|
|
Jobs::GenerateTopicThumbnails.jobs.size
|
|
}
|
|
|
|
thumbnails = topic_json["thumbnails"]
|
|
|
|
# Original + Optimized + 1 plugin request
|
|
expect(thumbnails.length).to eq(3)
|
|
end
|
|
end
|
|
end
|
|
end
|