mirror of
https://github.com/discourse/discourse.git
synced 2024-12-15 20:03:44 +08:00
4ea21fa2d0
This change both speeds up specs (less strings to allocate) and helps catch cases where methods in Discourse are mutating inputs. Overall we will be migrating everything to use #frozen_string_literal: true it will take a while, but this is the first and safest move in this direction
57 lines
1.3 KiB
Ruby
57 lines
1.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
require_dependency 'json_error'
|
|
|
|
shared_examples "a generic error" do
|
|
let(:result) { creator.create_errors_json(obj) }
|
|
|
|
it "should have a result object" do
|
|
expect(result).to be_present
|
|
end
|
|
|
|
it "has a generic error message" do
|
|
expect(result[:errors]).to eq([I18n.t('js.generic_error')])
|
|
end
|
|
end
|
|
|
|
describe JsonError do
|
|
|
|
let(:creator) { Object.new.extend(JsonError) }
|
|
|
|
describe "with a nil argument" do
|
|
it_behaves_like "a generic error" do
|
|
let(:obj) { nil }
|
|
end
|
|
end
|
|
|
|
describe "with an empty array" do
|
|
it_behaves_like "a generic error" do
|
|
let(:obj) { [] }
|
|
end
|
|
end
|
|
|
|
describe "with an activerecord object with no errors" do
|
|
it_behaves_like "a generic error" do
|
|
let(:obj) { Fabricate.build(:user) }
|
|
end
|
|
end
|
|
|
|
describe "with a string" do
|
|
it "returns the string in the error format" do
|
|
expect(creator.create_errors_json("test error")).to eq(errors: ["test error"])
|
|
end
|
|
end
|
|
|
|
describe "an activerecord objec with errors" do
|
|
let(:invalid_user) { User.new }
|
|
it "returns the errors correctly" do
|
|
expect(invalid_user).not_to be_valid
|
|
result = creator.create_errors_json(invalid_user)
|
|
expect(result).to be_present
|
|
expect(result[:errors]).not_to be_blank
|
|
end
|
|
end
|
|
|
|
end
|