github-mirror/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2024-11-24 07:24:51 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity
1c5b1ff5c2
fish-shell/tests/checks/pipeline-pgroup.fish

51 lines
1.6 KiB
Fish
Raw Normal View History

Add a test to verify that processes get the right pgrps in pipelines
2019-12-09 05:28:30 +08:00
# RUN: env fth=%fish_test_helper %fish %s
# Ensure that lots of nested jobs all end up in the same pgroup.
function save_pgroup -a var_name
$fth print_pgrp | read -g $var_name
end
# Here everything should live in the pgroup of the first fish_test_helper.
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-14 03:34:22 +08:00
$fth print_pgrp | read -g global_group | save_pgroup g1 | begin
save_pgroup g2
end
Add a test to verify that processes get the right pgrps in pipelines
2019-12-09 05:28:30 +08:00
[ "$global_group" -eq "$g1" ] && [ "$g1" -eq "$g2" ]
and echo "All pgroups agreed"
or echo "Pgroups disagreed. Should be in $global_group but found $g1 and $g2"
# CHECK: All pgroups agreed
# Here everything should live in fish's pgroup.
# Unfortunately we don't know what fish's pgroup is (it may not be fish's pid).
# So run it twice and verify that everything agrees; this implies that it could
# not have used any of the pids of the child procs.
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-14 03:34:22 +08:00
function nothing
end
nothing | $fth print_pgrp | read -g a0 | save_pgroup a1 | begin
save_pgroup a2
end
nothing | $fth print_pgrp | read -g b0 | save_pgroup b1 | begin
save_pgroup b2
end
Add a test to verify that processes get the right pgrps in pipelines
2019-12-09 05:28:30 +08:00
[ "$a0" -eq "$a1" ] && [ "$a1" -eq "$a2" ] \
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-14 03:34:22 +08:00
&& [ "$b0" -eq "$b1" ] && [ "$b1" -eq "$b2" ] \
&& [ "$a0" -eq "$b0" ]
Add a test to verify that processes get the right pgrps in pipelines
2019-12-09 05:28:30 +08:00
and echo "All pgroups agreed"
or echo "Pgroups disagreed. Found $a0 $a1 $a2, and $b0 $b1 $b2"
# CHECK: All pgroups agreed
Rationalize background-in-background procs If a background process runs a fish function which launches another background process, ensure that these background procs get different pgroups. Add a test for it.
2020-02-21 03:18:36 +08:00
# Ensure that if a background job launches another background job, that they have different pgroups.
# The pipeline here will arrange for the two pgroups to be printed on the same line, like:
# 123 124
# Our regex will capture the first pgroup and use a negative lookahead on the second.
status job-control full
$fth print_pgrp | begin
tr \n ' '
Correct a race condition in pipeline-pgroup test This test launches two background processes and is sensitive to interleaving of output. Fix it so that newlines are not output by the background process. Hopefully this fixes the flakiness of this test.
2020-03-03 06:00:20 +08:00
$fth print_pgrp | tr \n ' ' &
Rationalize background-in-background procs If a background process runs a fish function which launches another background process, ensure that these background procs get different pgroups. Add a test for it.
2020-02-21 03:18:36 +08:00
end &
wait
Correct a race condition in pipeline-pgroup test This test launches two background processes and is sensitive to interleaving of output. Fix it so that newlines are not output by the background process. Hopefully this fixes the flakiness of this test.
2020-03-03 06:00:20 +08:00
echo
Rationalize background-in-background procs If a background process runs a fish function which launches another background process, ensure that these background procs get different pgroups. Add a test for it.
2020-02-21 03:18:36 +08:00
# CHECK: {{(\d+) (?!\1)\d+}}
Reference in New Issue Copy Permalink