github-mirror/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2024-11-27 11:43:37 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity
3ef83de866
fish-shell/tests/checks/wraps.fish

42 lines
1.3 KiB
Fish
Raw Normal View History

Do not try the same (command, wraps) pair more than once when completing This prevents runaway wrap chains. Fixes #5638.
2019-09-22 04:38:59 +08:00
#RUN: %fish %s
# Validate some things about command wrapping.
Consolidate complete cycle detection and always report error on cycle Detect recursive calls to builtin complete and the internal completion in the same place. In 0a0149cc2 (Prevent infinite recursion when completion wraps variable assignment) we don't print an error when completing certain aliases like: alias vim "A=B vim" But we also gave no completions. We could make this case work, but I think that trying to salvage situations like this one is way too complex. Instead, let the user know by printing an error. Not sure if the style of the error fits. We could add some heuristic to alias to not add --wraps in some cyclic cases.
2020-09-26 20:13:56 +08:00
set -g LANG C # For predictable error messages.
Do not try the same (command, wraps) pair more than once when completing This prevents runaway wrap chains. Fixes #5638.
2019-09-22 04:38:59 +08:00
# This tests that we do not trigger a combinatorial explosion - see #5638.
Amend typos and grammar errors
2019-11-25 19:03:25 +08:00
# Ensure it completes successfully.
Do not try the same (command, wraps) pair more than once when completing This prevents runaway wrap chains. Fixes #5638.
2019-09-22 04:38:59 +08:00
complete -c testcommand --wraps "testcommand x "
complete -c testcommand --wraps "testcommand y "
complete -c testcommand --no-files -a normal
complete -C'testcommand '
# CHECK: normal
# We get the same completion twice. TODO: fix this.
# CHECK: normal
Completion wrap chain visited set to store only wrapped command The "wrap chain" refers to a sequence of commands which wrap other commands, for completion purposes. One possibility is that a wrap chain will produce a combinatorial explosion or even an infinite loop, so there needs to be logic to prevent that. Part of that logic is encapsulated in a visited set (wrap_chain_visited_set_t) to prevent exploring the same item twice. Prior to this change, we stored pairs (command, wrapped_command). But we only really need to store the wrapped command. Switch to that. One consequence is that if a command wraps another command in more than one way, we won't explore both ways. This seems unlikely in practice.
2020-09-27 04:39:47 +08:00
# Test double wraps.
complete -c testcommand0 -x -a crosswalk
complete -c testcommand1 -x --wraps testcommand0
complete -c testcommand2 -x --wraps testcommand1
complete -C 'testcommand 0'
# CHECK: crosswalk
Do not try the same (command, wraps) pair more than once when completing This prevents runaway wrap chains. Fixes #5638.
2019-09-22 04:38:59 +08:00
# This tests that a call to complete from within a completion doesn't trigger
# wrap chain explosion - #5638 again.
function testcommand2_complete
set -l tokens (commandline -opc) (commandline -ct)
set -e tokens[1]
echo $tokens 1>&2
end
complete -c testcommand2 -x -a "(testcommand2_complete)"
complete -c testcommand2 --wraps "testcommand2 from_wraps "
complete -C'testcommand2 explicit '
# CHECKERR: explicit
# CHECKERR: from_wraps explicit
Prevent infinite recursion when completion wraps variable assignment Closes #7344 Apply a targeted fix to the place where complete() is called to handle nested variable assignments. Sadly, reporting an error is probably not okay here, because people might legitimately use aliases like: alias vim "A=B command vim" This is all a bit ugly, and I hope to find a cleaner solution. Supporting completions on commandlines like `x=$PWD cd $x/ ` is a nice feature but it comes with some complexity.
2020-09-22 06:55:28 +08:00
complete -c recvar --wraps 'A=B recvar'
complete -C 'recvar '
Consolidate complete cycle detection and always report error on cycle Detect recursive calls to builtin complete and the internal completion in the same place. In 0a0149cc2 (Prevent infinite recursion when completion wraps variable assignment) we don't print an error when completing certain aliases like: alias vim "A=B vim" But we also gave no completions. We could make this case work, but I think that trying to salvage situations like this one is way too complex. Instead, let the user know by printing an error. Not sure if the style of the error fits. We could add some heuristic to alias to not add --wraps in some cyclic cases.
2020-09-26 20:13:56 +08:00
# CHECKERR: <E> fish: completion reached maximum recursion depth, possible cycle?
Reference in New Issue Copy Permalink