github-mirror/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2024-11-30 22:34:29 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity
425dabd6b1
fish-shell/tests/checks/realpath.fish

103 lines
4.1 KiB
Fish
Raw Normal View History

Port realpath tests to littlecheck I'm gonna add more tests to this and I don't want to touch the old stuff. Notice that this needs to have the output of the complete_directories test adjusted because this one now runs later. That's something we should take into account in future.
2019-07-03 04:59:38 +08:00
# RUN: %fish %s
make fish's realpath compatible with GNU realpath After implementing `builtin fish_realpath` it was noticed that it did not behave like GNU `realpath` without options. Which is super annoying since that was the whole point of implementing the command. Major failure on my part since I wrote the unit tests to match the behavior of the existing `wrealpath()` function that I simply exposed as a builtin command. Rather than actually verifying it behaved in a manner compatible with GNU realpath. Also, while the decision to call the builtin `fish_realpath` seemed to make sense at the time of the original commit further reflection has shown that to be a silly, idiosyncratic, thing to have done. So rename it to simply `realpath`. Fixes 3400
2016-10-04 08:51:27 +08:00
# $XDG_DATA_HOME can itself be a relative path. So force it to an absolute
# path so we can remove it from any resolved paths below. This is needed
# because the contents of the builtin realpath.out file can't include any $PWD
# data since $PWD isn't under our control.
set -l data_home_realpath (builtin realpath $XDG_DATA_HOME)
# A bogus absolute path is handled correctly and sets a failure status.
if not builtin realpath /this/better/be/an/invalid/path
echo first invalid path handled okay
Port realpath tests to littlecheck I'm gonna add more tests to this and I don't want to touch the old stuff. Notice that this needs to have the output of the complete_directories test adjusted because this one now runs later. That's something we should take into account in future.
2019-07-03 04:59:38 +08:00
# CHECK: first invalid path handled okay
# CHECKERR: builtin realpath: /this/better/be/an/invalid/path: No such file or directory
make fish's realpath compatible with GNU realpath After implementing `builtin fish_realpath` it was noticed that it did not behave like GNU `realpath` without options. Which is super annoying since that was the whole point of implementing the command. Major failure on my part since I wrote the unit tests to match the behavior of the existing `wrealpath()` function that I simply exposed as a builtin command. Rather than actually verifying it behaved in a manner compatible with GNU realpath. Also, while the decision to call the builtin `fish_realpath` seemed to make sense at the time of the original commit further reflection has shown that to be a silly, idiosyncratic, thing to have done. So rename it to simply `realpath`. Fixes 3400
2016-10-04 08:51:27 +08:00
end
# A non-existent file relative to $PWD succeeds.
set -l real_path (builtin realpath nonexistent-file)
Fix remaining realpath test issue with symlinks Pursuant to 0be79038590d3473b75252bf50ade2f62ea9c207, there still remained one issue with the test when run from within a symlinked directory after fish gained support for cding into symlinks. This change should make the test function OK both when the tests are run out of a PWD containing a symlink in its hierarchy and when run otherwise.
2019-04-05 11:25:45 +08:00
if test "$real_path" = (realpath $PWD)"/nonexistent-file"
make fish's realpath compatible with GNU realpath After implementing `builtin fish_realpath` it was noticed that it did not behave like GNU `realpath` without options. Which is super annoying since that was the whole point of implementing the command. Major failure on my part since I wrote the unit tests to match the behavior of the existing `wrealpath()` function that I simply exposed as a builtin command. Rather than actually verifying it behaved in a manner compatible with GNU realpath. Also, while the decision to call the builtin `fish_realpath` seemed to make sense at the time of the original commit further reflection has shown that to be a silly, idiosyncratic, thing to have done. So rename it to simply `realpath`. Fixes 3400
2016-10-04 08:51:27 +08:00
echo nonexistent-file in PWD correctly converted
Port realpath tests to littlecheck I'm gonna add more tests to this and I don't want to touch the old stuff. Notice that this needs to have the output of the complete_directories test adjusted because this one now runs later. That's something we should take into account in future.
2019-07-03 04:59:38 +08:00
# CHECK: nonexistent-file in PWD correctly converted
make fish's realpath compatible with GNU realpath After implementing `builtin fish_realpath` it was noticed that it did not behave like GNU `realpath` without options. Which is super annoying since that was the whole point of implementing the command. Major failure on my part since I wrote the unit tests to match the behavior of the existing `wrealpath()` function that I simply exposed as a builtin command. Rather than actually verifying it behaved in a manner compatible with GNU realpath. Also, while the decision to call the builtin `fish_realpath` seemed to make sense at the time of the original commit further reflection has shown that to be a silly, idiosyncratic, thing to have done. So rename it to simply `realpath`. Fixes 3400
2016-10-04 08:51:27 +08:00
end
# The simplest absolute path should undergo no transformation.
builtin realpath /
Port realpath tests to littlecheck I'm gonna add more tests to this and I don't want to touch the old stuff. Notice that this needs to have the output of the complete_directories test adjusted because this one now runs later. That's something we should take into account in future.
2019-07-03 04:59:38 +08:00
# CHECK: /
make fish's realpath compatible with GNU realpath After implementing `builtin fish_realpath` it was noticed that it did not behave like GNU `realpath` without options. Which is super annoying since that was the whole point of implementing the command. Major failure on my part since I wrote the unit tests to match the behavior of the existing `wrealpath()` function that I simply exposed as a builtin command. Rather than actually verifying it behaved in a manner compatible with GNU realpath. Also, while the decision to call the builtin `fish_realpath` seemed to make sense at the time of the original commit further reflection has shown that to be a silly, idiosyncratic, thing to have done. So rename it to simply `realpath`. Fixes 3400
2016-10-04 08:51:27 +08:00
# The second simplest absolute path should undergo no transformation.
builtin realpath /this-better-not-exist
Port realpath tests to littlecheck I'm gonna add more tests to this and I don't want to touch the old stuff. Notice that this needs to have the output of the complete_directories test adjusted because this one now runs later. That's something we should take into account in future.
2019-07-03 04:59:38 +08:00
# CHECK: /this-better-not-exist
make fish's realpath compatible with GNU realpath After implementing `builtin fish_realpath` it was noticed that it did not behave like GNU `realpath` without options. Which is super annoying since that was the whole point of implementing the command. Major failure on my part since I wrote the unit tests to match the behavior of the existing `wrealpath()` function that I simply exposed as a builtin command. Rather than actually verifying it behaved in a manner compatible with GNU realpath. Also, while the decision to call the builtin `fish_realpath` seemed to make sense at the time of the original commit further reflection has shown that to be a silly, idiosyncratic, thing to have done. So rename it to simply `realpath`. Fixes 3400
2016-10-04 08:51:27 +08:00
# Check that a pathological case is handled correctly (i.e., there is only one
# leading slash).
builtin realpath /../../x
Port realpath tests to littlecheck I'm gonna add more tests to this and I don't want to touch the old stuff. Notice that this needs to have the output of the complete_directories test adjusted because this one now runs later. That's something we should take into account in future.
2019-07-03 04:59:38 +08:00
# CHECK: /x
make fish's realpath compatible with GNU realpath After implementing `builtin fish_realpath` it was noticed that it did not behave like GNU `realpath` without options. Which is super annoying since that was the whole point of implementing the command. Major failure on my part since I wrote the unit tests to match the behavior of the existing `wrealpath()` function that I simply exposed as a builtin command. Rather than actually verifying it behaved in a manner compatible with GNU realpath. Also, while the decision to call the builtin `fish_realpath` seemed to make sense at the time of the original commit further reflection has shown that to be a silly, idiosyncratic, thing to have done. So rename it to simply `realpath`. Fixes 3400
2016-10-04 08:51:27 +08:00
# Another pathological corner case. GNU realpath first strips trailing slashes
# so that "/a//" is converted to "/a" before performing the real path
# conversion. So, despite appearances, it considers "a" to be the last
# component in that case.
builtin realpath /abc/
Port realpath tests to littlecheck I'm gonna add more tests to this and I don't want to touch the old stuff. Notice that this needs to have the output of the complete_directories test adjusted because this one now runs later. That's something we should take into account in future.
2019-07-03 04:59:38 +08:00
# CHECK: /abc
make fish's realpath compatible with GNU realpath After implementing `builtin fish_realpath` it was noticed that it did not behave like GNU `realpath` without options. Which is super annoying since that was the whole point of implementing the command. Major failure on my part since I wrote the unit tests to match the behavior of the existing `wrealpath()` function that I simply exposed as a builtin command. Rather than actually verifying it behaved in a manner compatible with GNU realpath. Also, while the decision to call the builtin `fish_realpath` seemed to make sense at the time of the original commit further reflection has shown that to be a silly, idiosyncratic, thing to have done. So rename it to simply `realpath`. Fixes 3400
2016-10-04 08:51:27 +08:00
builtin realpath /def///
Port realpath tests to littlecheck I'm gonna add more tests to this and I don't want to touch the old stuff. Notice that this needs to have the output of the complete_directories test adjusted because this one now runs later. That's something we should take into account in future.
2019-07-03 04:59:38 +08:00
# CHECK: /def
make fish's realpath compatible with GNU realpath After implementing `builtin fish_realpath` it was noticed that it did not behave like GNU `realpath` without options. Which is super annoying since that was the whole point of implementing the command. Major failure on my part since I wrote the unit tests to match the behavior of the existing `wrealpath()` function that I simply exposed as a builtin command. Rather than actually verifying it behaved in a manner compatible with GNU realpath. Also, while the decision to call the builtin `fish_realpath` seemed to make sense at the time of the original commit further reflection has shown that to be a silly, idiosyncratic, thing to have done. So rename it to simply `realpath`. Fixes 3400
2016-10-04 08:51:27 +08:00
Improve realpath error reporting, fix a crasher realpath() will return NULL and sets errno if it fails. We asserted that realpath(".") does not fail. We also didn't really check that it was successful. Made sure we'll get a perror telling us about what went wrong if something like this happens again. Updated tests and added test case Fixes #5351
2018-11-19 00:56:24 +08:00
# Verify `realpath .` when cwd is a deleted directory gives a no such file or dir error.
set -l tmpdir (mktemp -d)
pushd $tmpdir
tests/realpath.in: We want to delete $PWD, darnit! Illumos/OpenIndiana/SunOS/Solaris has an rm/rmdir that tries to protect the user by not allowing them to delete $PWD. Normally, this would be a good thing as deleting $PWD is a stupid thing to do. Except in this case, we absolutely need to do that. So instead we weasel around it by invoking an sh to cd out of the directory to then invoke an `rmdir` to delete it. That should throw off any attempts at protection (we could also have tried $PWD/. or similar, but that's possibly still protected against). This is the last failing test on Illumos/OpenIndiana/SunOS/Solaris/afunnyquip, so: Fixes #5472.
2019-01-19 05:54:09 +08:00
# Solaris rmdir tries to protect against deleting $PWD.
# But that's what we want to test, so we weasel around it.
sh -c "cd ..; rmdir $tmpdir"
Improve realpath error reporting, fix a crasher realpath() will return NULL and sets errno if it fails. We asserted that realpath(".") does not fail. We also didn't really check that it was successful. Made sure we'll get a perror telling us about what went wrong if something like this happens again. Updated tests and added test case Fixes #5351
2018-11-19 00:56:24 +08:00
builtin realpath .
Port realpath tests to littlecheck I'm gonna add more tests to this and I don't want to touch the old stuff. Notice that this needs to have the output of the complete_directories test adjusted because this one now runs later. That's something we should take into account in future.
2019-07-03 04:59:38 +08:00
# CHECKERR: builtin realpath: .: No such file or directory
Improve realpath error reporting, fix a crasher realpath() will return NULL and sets errno if it fails. We asserted that realpath(".") does not fail. We also didn't really check that it was successful. Made sure we'll get a perror telling us about what went wrong if something like this happens again. Updated tests and added test case Fixes #5351
2018-11-19 00:56:24 +08:00
popd
make fish's realpath compatible with GNU realpath After implementing `builtin fish_realpath` it was noticed that it did not behave like GNU `realpath` without options. Which is super annoying since that was the whole point of implementing the command. Major failure on my part since I wrote the unit tests to match the behavior of the existing `wrealpath()` function that I simply exposed as a builtin command. Rather than actually verifying it behaved in a manner compatible with GNU realpath. Also, while the decision to call the builtin `fish_realpath` seemed to make sense at the time of the original commit further reflection has shown that to be a silly, idiosyncratic, thing to have done. So rename it to simply `realpath`. Fixes 3400
2016-10-04 08:51:27 +08:00
# A single symlink to a directory is correctly resolved.
Force symlink creation in realpath tests If an earlier test was aborted, the symlink would still be present and the subsequent run will fail to create the symlink as it wasn't forced.
2019-12-19 02:31:24 +08:00
ln -fs fish $XDG_DATA_HOME/fish-symlink
make fish's realpath compatible with GNU realpath After implementing `builtin fish_realpath` it was noticed that it did not behave like GNU `realpath` without options. Which is super annoying since that was the whole point of implementing the command. Major failure on my part since I wrote the unit tests to match the behavior of the existing `wrealpath()` function that I simply exposed as a builtin command. Rather than actually verifying it behaved in a manner compatible with GNU realpath. Also, while the decision to call the builtin `fish_realpath` seemed to make sense at the time of the original commit further reflection has shown that to be a silly, idiosyncratic, thing to have done. So rename it to simply `realpath`. Fixes 3400
2016-10-04 08:51:27 +08:00
set -l real_path (builtin realpath $XDG_DATA_HOME/fish-symlink)
set -l expected_real_path "$data_home_realpath/fish"
if test "$real_path" = "$expected_real_path"
echo "fish-symlink handled correctly"
Port realpath tests to littlecheck I'm gonna add more tests to this and I don't want to touch the old stuff. Notice that this needs to have the output of the complete_directories test adjusted because this one now runs later. That's something we should take into account in future.
2019-07-03 04:59:38 +08:00
# CHECK: fish-symlink handled correctly
make fish's realpath compatible with GNU realpath After implementing `builtin fish_realpath` it was noticed that it did not behave like GNU `realpath` without options. Which is super annoying since that was the whole point of implementing the command. Major failure on my part since I wrote the unit tests to match the behavior of the existing `wrealpath()` function that I simply exposed as a builtin command. Rather than actually verifying it behaved in a manner compatible with GNU realpath. Also, while the decision to call the builtin `fish_realpath` seemed to make sense at the time of the original commit further reflection has shown that to be a silly, idiosyncratic, thing to have done. So rename it to simply `realpath`. Fixes 3400
2016-10-04 08:51:27 +08:00
else
echo "fish-symlink not handled correctly: $real_path != $expected_real_path" >&2
end
builtin realpath: Add --no-symlinks option Taken from GNU realpath, this one makes realpath not resolve symlinks. It still makes paths absolute and handles duplicate and trailing slashes. (useful in fish_add_path)
2020-09-13 01:26:04 +08:00
# With "-s" the symlink is not resolved.
set -l real_path (builtin realpath -s $XDG_DATA_HOME/fish-symlink)
set -l expected_real_path "$XDG_DATA_HOME/fish-symlink"
if test "$real_path" = "$expected_real_path"
echo "fish-symlink handled correctly"
# CHECK: fish-symlink handled correctly
else
echo "fish-symlink not handled correctly: $real_path != $expected_real_path" >&2
end
test (builtin realpath -s /usr/bin/../) = "/usr"
or echo builtin realpath -s does not resolve .. or resolves symlink wrong
make fish's realpath compatible with GNU realpath After implementing `builtin fish_realpath` it was noticed that it did not behave like GNU `realpath` without options. Which is super annoying since that was the whole point of implementing the command. Major failure on my part since I wrote the unit tests to match the behavior of the existing `wrealpath()` function that I simply exposed as a builtin command. Rather than actually verifying it behaved in a manner compatible with GNU realpath. Also, while the decision to call the builtin `fish_realpath` seemed to make sense at the time of the original commit further reflection has shown that to be a silly, idiosyncratic, thing to have done. So rename it to simply `realpath`. Fixes 3400
2016-10-04 08:51:27 +08:00
# A nonexistent file relative to a valid symlink to a directory gets converted.
# This depends on the symlink created by the previous test.
set -l real_path (builtin realpath $XDG_DATA_HOME/fish-symlink/nonexistent-file-relative-to-a-symlink)
set -l expected_real_path "$data_home_realpath/fish/nonexistent-file-relative-to-a-symlink"
if test "$real_path" = "$expected_real_path"
echo "fish-symlink/nonexistent-file-relative-to-a-symlink correctly converted"
Port realpath tests to littlecheck I'm gonna add more tests to this and I don't want to touch the old stuff. Notice that this needs to have the output of the complete_directories test adjusted because this one now runs later. That's something we should take into account in future.
2019-07-03 04:59:38 +08:00
# CHECK: fish-symlink/nonexistent-file-relative-to-a-symlink correctly converted
make fish's realpath compatible with GNU realpath After implementing `builtin fish_realpath` it was noticed that it did not behave like GNU `realpath` without options. Which is super annoying since that was the whole point of implementing the command. Major failure on my part since I wrote the unit tests to match the behavior of the existing `wrealpath()` function that I simply exposed as a builtin command. Rather than actually verifying it behaved in a manner compatible with GNU realpath. Also, while the decision to call the builtin `fish_realpath` seemed to make sense at the time of the original commit further reflection has shown that to be a silly, idiosyncratic, thing to have done. So rename it to simply `realpath`. Fixes 3400
2016-10-04 08:51:27 +08:00
else
echo "failure nonexistent-file-relative-to-a-symlink: $real_path != $expected_real_path" >&2
end
# A path with two symlinks, first to a directory, second to a file, is correctly resolved.
Force symlink creation in realpath tests If an earlier test was aborted, the symlink would still be present and the subsequent run will fail to create the symlink as it wasn't forced.
2019-12-19 02:31:24 +08:00
ln -fs fish $XDG_DATA_HOME/fish-symlink2
make fish's realpath compatible with GNU realpath After implementing `builtin fish_realpath` it was noticed that it did not behave like GNU `realpath` without options. Which is super annoying since that was the whole point of implementing the command. Major failure on my part since I wrote the unit tests to match the behavior of the existing `wrealpath()` function that I simply exposed as a builtin command. Rather than actually verifying it behaved in a manner compatible with GNU realpath. Also, while the decision to call the builtin `fish_realpath` seemed to make sense at the time of the original commit further reflection has shown that to be a silly, idiosyncratic, thing to have done. So rename it to simply `realpath`. Fixes 3400
2016-10-04 08:51:27 +08:00
touch $XDG_DATA_HOME/fish/real_file
Force symlink creation in realpath tests If an earlier test was aborted, the symlink would still be present and the subsequent run will fail to create the symlink as it wasn't forced.
2019-12-19 02:31:24 +08:00
ln -fs real_file $XDG_DATA_HOME/fish/symlink_file
make fish's realpath compatible with GNU realpath After implementing `builtin fish_realpath` it was noticed that it did not behave like GNU `realpath` without options. Which is super annoying since that was the whole point of implementing the command. Major failure on my part since I wrote the unit tests to match the behavior of the existing `wrealpath()` function that I simply exposed as a builtin command. Rather than actually verifying it behaved in a manner compatible with GNU realpath. Also, while the decision to call the builtin `fish_realpath` seemed to make sense at the time of the original commit further reflection has shown that to be a silly, idiosyncratic, thing to have done. So rename it to simply `realpath`. Fixes 3400
2016-10-04 08:51:27 +08:00
set -l real_path (builtin realpath $XDG_DATA_HOME/fish-symlink/symlink_file)
set -l expected_real_path "$data_home_realpath/fish/real_file"
if test "$real_path" = "$expected_real_path"
echo "fish-symlink/symlink_file handled correctly"
Port realpath tests to littlecheck I'm gonna add more tests to this and I don't want to touch the old stuff. Notice that this needs to have the output of the complete_directories test adjusted because this one now runs later. That's something we should take into account in future.
2019-07-03 04:59:38 +08:00
# CHECK: fish-symlink/symlink_file handled correctly
make fish's realpath compatible with GNU realpath After implementing `builtin fish_realpath` it was noticed that it did not behave like GNU `realpath` without options. Which is super annoying since that was the whole point of implementing the command. Major failure on my part since I wrote the unit tests to match the behavior of the existing `wrealpath()` function that I simply exposed as a builtin command. Rather than actually verifying it behaved in a manner compatible with GNU realpath. Also, while the decision to call the builtin `fish_realpath` seemed to make sense at the time of the original commit further reflection has shown that to be a silly, idiosyncratic, thing to have done. So rename it to simply `realpath`. Fixes 3400
2016-10-04 08:51:27 +08:00
else
echo "fish-symlink/symlink_file not handled correctly: $real_path != expected_real_path" >&2
end
exit 0
Reference in New Issue Copy Permalink