github-mirror/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2024-12-05 09:43:42 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity
662fde7b71
fish-shell/tests/checks/tmux-complete.fish

87 lines
3.1 KiB
Fish
Raw Normal View History

Extract setup and teardown for tmux tests This was long overdue since the setup logic is much more complex than the actual tests. tmux-prompt.fish had extra logic to protect against XDG_CONFIG_HOME with leading double double-dot. I believe this is no longer necessary with the new test driver. We still use our own temp dir because we want to be able to run this independently of the test driver, This can be useful for debugging tests. For example we can insert a "$tmux attach" command in a test, and then run build/fish -C 'source tests/test_functions/isolated-tmux.fish' tests/checks/tmux-bind.fish This allows to inspect the state of the test and debug interactively. Attaching to the terminal doesn't work when running inside littlecheck because littlecheck consumes our output and doesn't give us a terminal. (Maybe there's an easy way to fix that?)
2021-08-29 15:44:22 +08:00
#RUN: %fish %s
Use the correct case in completion pager (#7744) Consider $ complete -c foo -a 'aab aaB' -f $ foo A<TAB> since 28d67c8 we would insert the common prefix AND show the pager. Due to case-insensitive comparison, "b/B" was considered to be part of the prefix. Since the prefix is added to each pager item [1] we get wrong results. Fix this by removing the insensitive comparison between completions - I don't think it was of much use anyway. Commandline tokens are still matched case-insensitively, this is just about completions. Test this by running interactive fish inside tmux (pexpect's terminal emulation not have enough capabilities). Also add tests for recent interactive regressions #7526 and #7738. Closes #3978 [1]: b38a23a would solve this differently by giving every pager item its own prefix, but was reverted since it needs more fixes.
2021-03-21 16:25:29 +08:00
#REQUIRES: command -v tmux
Skip tmux-complete test under WSL The test passes but only if executed on its own. It's not the most perfect test, but I can basically never get `make test` to pass under WSL while that's not the case on all my other machines.
2023-03-13 04:16:00 +08:00
#REQUIRES: uname -r | grep -qv Microsoft
tests: More slack for ASAN Disable one and add a sleep to another
2023-05-12 04:14:12 +08:00
# disable on github actions because it's flakey
#REQUIRES: test -z "$CI"
Use the correct case in completion pager (#7744) Consider $ complete -c foo -a 'aab aaB' -f $ foo A<TAB> since 28d67c8 we would insert the common prefix AND show the pager. Due to case-insensitive comparison, "b/B" was considered to be part of the prefix. Since the prefix is added to each pager item [1] we get wrong results. Fix this by removing the insensitive comparison between completions - I don't think it was of much use anyway. Commandline tokens are still matched case-insensitively, this is just about completions. Test this by running interactive fish inside tmux (pexpect's terminal emulation not have enough capabilities). Also add tests for recent interactive regressions #7526 and #7738. Closes #3978 [1]: b38a23a would solve this differently by giving every pager item its own prefix, but was reverted since it needs more fixes.
2021-03-21 16:25:29 +08:00
isolated-tmux to more reliably initialize and other fixes Prior to this change, tmux based tests would call 'isolated-tmux' which would initialize tmux on first call, an admitted "evil hack." Switch to requiring an explicit call to 'isolated-tmux-start' which then defines 'isolated-tmux' and other functions. Add some loop-until-prompt logic into 'isolated-tmux-start'. This improves reliability of the tmux tests on systems under load; at least it makes the tests pass in the background on my Mac. Remove the '$sleep' variable, to be replaced with 'tmux-sleep'.
2021-09-24 23:07:17 +08:00
isolated-tmux-start
Use the correct case in completion pager (#7744) Consider $ complete -c foo -a 'aab aaB' -f $ foo A<TAB> since 28d67c8 we would insert the common prefix AND show the pager. Due to case-insensitive comparison, "b/B" was considered to be part of the prefix. Since the prefix is added to each pager item [1] we get wrong results. Fix this by removing the insensitive comparison between completions - I don't think it was of much use anyway. Commandline tokens are still matched case-insensitively, this is just about completions. Test this by running interactive fish inside tmux (pexpect's terminal emulation not have enough capabilities). Also add tests for recent interactive regressions #7526 and #7738. Closes #3978 [1]: b38a23a would solve this differently by giving every pager item its own prefix, but was reverted since it needs more fixes.
2021-03-21 16:25:29 +08:00
# Don't escape existing token (#7526).
echo >file-1
echo >file-2
Extract setup and teardown for tmux tests This was long overdue since the setup logic is much more complex than the actual tests. tmux-prompt.fish had extra logic to protect against XDG_CONFIG_HOME with leading double double-dot. I believe this is no longer necessary with the new test driver. We still use our own temp dir because we want to be able to run this independently of the test driver, This can be useful for debugging tests. For example we can insert a "$tmux attach" command in a test, and then run build/fish -C 'source tests/test_functions/isolated-tmux.fish' tests/checks/tmux-bind.fish This allows to inspect the state of the test and debug interactively. Attaching to the terminal doesn't work when running inside littlecheck because littlecheck consumes our output and doesn't give us a terminal. (Maybe there's an easy way to fix that?)
2021-08-29 15:44:22 +08:00
isolated-tmux send-keys 'HOME=$PWD ls ~/' Tab
isolated-tmux to more reliably initialize and other fixes Prior to this change, tmux based tests would call 'isolated-tmux' which would initialize tmux on first call, an admitted "evil hack." Switch to requiring an explicit call to 'isolated-tmux-start' which then defines 'isolated-tmux' and other functions. Add some loop-until-prompt logic into 'isolated-tmux-start'. This improves reliability of the tmux tests on systems under load; at least it makes the tests pass in the background on my Mac. Remove the '$sleep' variable, to be replaced with 'tmux-sleep'.
2021-09-24 23:07:17 +08:00
tmux-sleep
Extract setup and teardown for tmux tests This was long overdue since the setup logic is much more complex than the actual tests. tmux-prompt.fish had extra logic to protect against XDG_CONFIG_HOME with leading double double-dot. I believe this is no longer necessary with the new test driver. We still use our own temp dir because we want to be able to run this independently of the test driver, This can be useful for debugging tests. For example we can insert a "$tmux attach" command in a test, and then run build/fish -C 'source tests/test_functions/isolated-tmux.fish' tests/checks/tmux-bind.fish This allows to inspect the state of the test and debug interactively. Attaching to the terminal doesn't work when running inside littlecheck because littlecheck consumes our output and doesn't give us a terminal. (Maybe there's an easy way to fix that?)
2021-08-29 15:44:22 +08:00
isolated-tmux capture-pane -p
Partially fix the tmux-complete test The autosuggestion was creeping in, causing us to sometimes show file-1 and sometimes just file-. Allow the race through a regular expression.
2021-04-12 09:13:39 +08:00
# Note the contents may or may not have the autosuggestion appended - it is a race.
# CHECK: prompt 0> HOME=$PWD ls ~/file-{{1?}}
Use the correct case in completion pager (#7744) Consider $ complete -c foo -a 'aab aaB' -f $ foo A<TAB> since 28d67c8 we would insert the common prefix AND show the pager. Due to case-insensitive comparison, "b/B" was considered to be part of the prefix. Since the prefix is added to each pager item [1] we get wrong results. Fix this by removing the insensitive comparison between completions - I don't think it was of much use anyway. Commandline tokens are still matched case-insensitively, this is just about completions. Test this by running interactive fish inside tmux (pexpect's terminal emulation not have enough capabilities). Also add tests for recent interactive regressions #7526 and #7738. Closes #3978 [1]: b38a23a would solve this differently by giving every pager item its own prefix, but was reverted since it needs more fixes.
2021-03-21 16:25:29 +08:00
# CHECK: ~/file-1 ~/file-2
# No pager on single smartcase completion (#7738).
Extract setup and teardown for tmux tests This was long overdue since the setup logic is much more complex than the actual tests. tmux-prompt.fish had extra logic to protect against XDG_CONFIG_HOME with leading double double-dot. I believe this is no longer necessary with the new test driver. We still use our own temp dir because we want to be able to run this independently of the test driver, This can be useful for debugging tests. For example we can insert a "$tmux attach" command in a test, and then run build/fish -C 'source tests/test_functions/isolated-tmux.fish' tests/checks/tmux-bind.fish This allows to inspect the state of the test and debug interactively. Attaching to the terminal doesn't work when running inside littlecheck because littlecheck consumes our output and doesn't give us a terminal. (Maybe there's an easy way to fix that?)
2021-08-29 15:44:22 +08:00
isolated-tmux send-keys C-u C-l 'mkdir cmake CMakeFiles' Enter C-l \
Use the correct case in completion pager (#7744) Consider $ complete -c foo -a 'aab aaB' -f $ foo A<TAB> since 28d67c8 we would insert the common prefix AND show the pager. Due to case-insensitive comparison, "b/B" was considered to be part of the prefix. Since the prefix is added to each pager item [1] we get wrong results. Fix this by removing the insensitive comparison between completions - I don't think it was of much use anyway. Commandline tokens are still matched case-insensitively, this is just about completions. Test this by running interactive fish inside tmux (pexpect's terminal emulation not have enough capabilities). Also add tests for recent interactive regressions #7526 and #7738. Closes #3978 [1]: b38a23a would solve this differently by giving every pager item its own prefix, but was reverted since it needs more fixes.
2021-03-21 16:25:29 +08:00
'cat cmake' Tab
isolated-tmux to more reliably initialize and other fixes Prior to this change, tmux based tests would call 'isolated-tmux' which would initialize tmux on first call, an admitted "evil hack." Switch to requiring an explicit call to 'isolated-tmux-start' which then defines 'isolated-tmux' and other functions. Add some loop-until-prompt logic into 'isolated-tmux-start'. This improves reliability of the tmux tests on systems under load; at least it makes the tests pass in the background on my Mac. Remove the '$sleep' variable, to be replaced with 'tmux-sleep'.
2021-09-24 23:07:17 +08:00
tmux-sleep
Extract setup and teardown for tmux tests This was long overdue since the setup logic is much more complex than the actual tests. tmux-prompt.fish had extra logic to protect against XDG_CONFIG_HOME with leading double double-dot. I believe this is no longer necessary with the new test driver. We still use our own temp dir because we want to be able to run this independently of the test driver, This can be useful for debugging tests. For example we can insert a "$tmux attach" command in a test, and then run build/fish -C 'source tests/test_functions/isolated-tmux.fish' tests/checks/tmux-bind.fish This allows to inspect the state of the test and debug interactively. Attaching to the terminal doesn't work when running inside littlecheck because littlecheck consumes our output and doesn't give us a terminal. (Maybe there's an easy way to fix that?)
2021-08-29 15:44:22 +08:00
isolated-tmux capture-pane -p
Use the correct case in completion pager (#7744) Consider $ complete -c foo -a 'aab aaB' -f $ foo A<TAB> since 28d67c8 we would insert the common prefix AND show the pager. Due to case-insensitive comparison, "b/B" was considered to be part of the prefix. Since the prefix is added to each pager item [1] we get wrong results. Fix this by removing the insensitive comparison between completions - I don't think it was of much use anyway. Commandline tokens are still matched case-insensitively, this is just about completions. Test this by running interactive fish inside tmux (pexpect's terminal emulation not have enough capabilities). Also add tests for recent interactive regressions #7526 and #7738. Closes #3978 [1]: b38a23a would solve this differently by giving every pager item its own prefix, but was reverted since it needs more fixes.
2021-03-21 16:25:29 +08:00
# CHECK: prompt 1> cat cmake/
Fix typo
2021-03-21 04:34:08 +08:00
# Correct case in pager when prefixes differ in case (#7743).
Extract setup and teardown for tmux tests This was long overdue since the setup logic is much more complex than the actual tests. tmux-prompt.fish had extra logic to protect against XDG_CONFIG_HOME with leading double double-dot. I believe this is no longer necessary with the new test driver. We still use our own temp dir because we want to be able to run this independently of the test driver, This can be useful for debugging tests. For example we can insert a "$tmux attach" command in a test, and then run build/fish -C 'source tests/test_functions/isolated-tmux.fish' tests/checks/tmux-bind.fish This allows to inspect the state of the test and debug interactively. Attaching to the terminal doesn't work when running inside littlecheck because littlecheck consumes our output and doesn't give us a terminal. (Maybe there's an easy way to fix that?)
2021-08-29 15:44:22 +08:00
isolated-tmux send-keys C-u C-l 'complete -c foo2 -a "aabc aaBd" -f' Enter C-l \
Use the correct case in completion pager (#7744) Consider $ complete -c foo -a 'aab aaB' -f $ foo A<TAB> since 28d67c8 we would insert the common prefix AND show the pager. Due to case-insensitive comparison, "b/B" was considered to be part of the prefix. Since the prefix is added to each pager item [1] we get wrong results. Fix this by removing the insensitive comparison between completions - I don't think it was of much use anyway. Commandline tokens are still matched case-insensitively, this is just about completions. Test this by running interactive fish inside tmux (pexpect's terminal emulation not have enough capabilities). Also add tests for recent interactive regressions #7526 and #7738. Closes #3978 [1]: b38a23a would solve this differently by giving every pager item its own prefix, but was reverted since it needs more fixes.
2021-03-21 16:25:29 +08:00
'foo2 A' Tab
isolated-tmux to more reliably initialize and other fixes Prior to this change, tmux based tests would call 'isolated-tmux' which would initialize tmux on first call, an admitted "evil hack." Switch to requiring an explicit call to 'isolated-tmux-start' which then defines 'isolated-tmux' and other functions. Add some loop-until-prompt logic into 'isolated-tmux-start'. This improves reliability of the tmux tests on systems under load; at least it makes the tests pass in the background on my Mac. Remove the '$sleep' variable, to be replaced with 'tmux-sleep'.
2021-09-24 23:07:17 +08:00
tmux-sleep
Extract setup and teardown for tmux tests This was long overdue since the setup logic is much more complex than the actual tests. tmux-prompt.fish had extra logic to protect against XDG_CONFIG_HOME with leading double double-dot. I believe this is no longer necessary with the new test driver. We still use our own temp dir because we want to be able to run this independently of the test driver, This can be useful for debugging tests. For example we can insert a "$tmux attach" command in a test, and then run build/fish -C 'source tests/test_functions/isolated-tmux.fish' tests/checks/tmux-bind.fish This allows to inspect the state of the test and debug interactively. Attaching to the terminal doesn't work when running inside littlecheck because littlecheck consumes our output and doesn't give us a terminal. (Maybe there's an easy way to fix that?)
2021-08-29 15:44:22 +08:00
isolated-tmux capture-pane -p
# The "bc" part is the autosuggestion - we could use "capture-pane -e" to check colors.
Use the correct case in completion pager (#7744) Consider $ complete -c foo -a 'aab aaB' -f $ foo A<TAB> since 28d67c8 we would insert the common prefix AND show the pager. Due to case-insensitive comparison, "b/B" was considered to be part of the prefix. Since the prefix is added to each pager item [1] we get wrong results. Fix this by removing the insensitive comparison between completions - I don't think it was of much use anyway. Commandline tokens are still matched case-insensitively, this is just about completions. Test this by running interactive fish inside tmux (pexpect's terminal emulation not have enough capabilities). Also add tests for recent interactive regressions #7526 and #7738. Closes #3978 [1]: b38a23a would solve this differently by giving every pager item its own prefix, but was reverted since it needs more fixes.
2021-03-21 16:25:29 +08:00
# CHECK: prompt 2> foo2 aabc
# CHECK: aabc aaBd
Fix completion pager rendering when there are lines after cursor When the completion pager fills up all lines of the screen, we subtract from the pager size the number of lines occupied by the prompt + command line buffer (typically 1), so the command line is always visible. However, we only subtract the number of lines *before* the cursor, so on some multiline commandlines we draw a pager that is too large for our screen, clobbering the commandline rendering. Fix this by counting all lines. Fixes #8509 Possibly fixes #8405
2021-12-02 11:40:55 +08:00
# Check that a larger-than-screen completion list does not stomp a multiline commandline (#8509).
isolated-tmux send-keys C-u 'complete -c foo3 -fa "(seq $LINES)\t(string repeat -n $COLUMNS d)"' Enter \
C-l begin Enter foo3 Enter "echo some trailing line" \
C-p C-e Space Tab Tab
tmux-sleep
isolated-tmux capture-pane -p | sed -n '1p;$p'
# Assert that we didn't change the command line.
# CHECK: prompt 3> begin
# Also ensure that the pager is actually fully disclosed.
Fix tmux-complete test on macOS CI For some reason, the window dimension parameters are ignored by tmux. Not even an extra "resize-pane -x 80 -y 10" helps. So let's just drop that assumption from our tests.
2021-12-02 22:06:47 +08:00
# CHECK: rows 1 to {{\d+}} of {{\d+}}
Fix Escape in pager not removing the inserted completion if search field was used command_line_has_transient_edit tracks the actual command line, not the pager search field. We accidentally reset it after modifying the search field which causes unexpected behavior - the commandline added by the completion pager remains even after I press Escape.
2022-07-26 15:23:44 +08:00
# Canceling the pager removes the inserted completion, no mater what happens in the search field.
# The common prefix remains because it is inserted before the pager is shown.
isolated-tmux send-keys C-c
tmux-sleep
isolated-tmux send-keys C-l foo2 Space BTab b BSpace b Escape
tmux-sleep
isolated-tmux capture-pane -p
# CHECK: prompt 3> foo2 aa
Fix "commandline --paging-mode" false negative when there is no room for pager, attempt 2 The previous fix was reverted because it broke another scenario. Add tests for both scenarios. The first test exposes another problem: autosuggestions are sometimes not recomputed after selecting the first completion with Tab Tab. Fix that too.
2022-07-31 13:06:10 +08:00
# Check that down-or-search works even when the pager is not selected.
isolated-tmux send-keys C-u foo2 Space Tab
tmux-sleep
isolated-tmux send-keys Down
tmux-sleep
isolated-tmux capture-pane -p
# Also check that we show an autosuggestion.
# CHECK: prompt 3> foo2 aabc aabc
# CHECK: aabc{{ *}}aaBd
# Check that a larger-than-screen completion does not break down-or-search.
isolated-tmux send-keys C-u 'complete -c foo4 -f -a "
a-long-arg-\"$(seq $LINES | string pad -c_ --width $COLUMNS)\"
b-short-arg"' Enter C-l foo4 Space Tab Tab Down
tmux-sleep
isolated-tmux capture-pane -p | head -1
# The second one is the autosuggestion. Maybe we should turn them off for this test.
# TODO there should be a prefix ("prompt 4> foo4") but we fail to draw that in this case.
# CHECK: {{.*}} b-short-arg a-long-arg{{.*}}
Commit transient edit when closing pager When selecting items in the pager, only the latest of those items is kept in the edit history, as so-called transient edit. Each new transient edit evicts any old transient edit (via undo). If the pager is closed by a command that performs another transient edit (like history-token-search-backward) we thus inadvertently undo (= remove) the token inserted by the pager. Fix this by closing a transient edit session when closing the pager. Token search will start its own session. Fixes #9160
2022-08-31 13:33:46 +08:00
# Check that completion pager followed by token search search inserts two separate tokens.
isolated-tmux send-keys C-u echo Space old-arg Enter C-l foo2 Space Tab Tab M-.
tmux-sleep
isolated-tmux capture-pane -p
# CHECK: prompt 5> foo2 aabc old-arg
Show autosuggestion again after undoing deletion Commit e5b34d5cd (Suppress autosuggesting during backspacing like browsers do, 2012-02-06) disabled autosuggestion when backspacing. Autosuggestions are re-enabled whenever we insert anything in the command line. Undo uses a different code path to insert into the command line, which does not re-enable autosuggestion. Fix that. Also re-enable autosuggestion when undo erases from the command line. This seems like the simplest approach. It's not clear if there's a better behavior; browsers don't agree on one in any case.
2024-02-07 06:49:59 +08:00
isolated-tmux send-keys C-u 'echo suggest this' Enter C-l
tmux-sleep
isolated-tmux send-keys 'echo sug' C-w C-z
tmux-sleep
isolated-tmux capture-pane -p
# CHECK: prompt 6> echo suggest this
Reference in New Issue Copy Permalink