github-mirror/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2024-12-25 11:43:40 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity
6896898769
fish-shell/fish-rust/src/lib.rs

109 lines
2.4 KiB
Rust
Raw Normal View History

Add [lints] table to suppress lints across all our crates This was stabilized in 1.74. Until that's our MSRV, keep the warnings also in "lib.rs", to prevent warning spew on old builds (CI logs etc.).
2024-01-12 21:00:00 +08:00
// Delete this once we require Rust 1.74.
Port perf_convert_ascii The "#[bench]" attribute is not allowed in stable Rust, so keep it behind a new feature flag. Run on nightly Rust with $ cargo bench --features=bechmark test tests::encoding::bench::bench_convert_ascii ... bench: 125,988 ns/iter (+/- 1,128) = 1040 MB/s
2023-12-10 15:48:18 +08:00
#![cfg_attr(feature = "benchmark", feature(test))]
Initial Rust commit
2023-01-15 06:56:24 +08:00
#![allow(non_camel_case_types)]
#![allow(dead_code)]
#![allow(non_upper_case_globals)]
Disable unstable_name_collisions warning We rarely attach trait methods to stdlib types so this warning is unlikely to be a true positive It is a false positive for the methods defined in future.rs. It's not always obvious which method is selected when it's available in the stdlib but I haven't seen a build failure yet. So let's disable the warning. In future we might be able suppress it per method, see Rust issue 48919.
2023-12-07 01:36:13 +08:00
#![allow(unstable_name_collisions)]
Silence some more clippy lints bool_assert_comparison is stupid, the reason they give is "it's shorter". Well, `assert!(!foo)` is nowhere near as readable as `assert_eq!(foo, false)` because of the ! noise from the macro. Uninlined format args is a stupid lint that Rust actually walked back when they made it an official warning because you still have to use a mix of inlined and un-inlined format args (the latter of which won't complain) since only idents can be inlined.
2023-03-05 14:54:17 +08:00
#![allow(clippy::bool_assert_comparison)]
Port execution Drop support for history file version 1. ParseExecutionContext no longer contains an OperationContext because in my first implementation, ParseExecutionContext didn't have interior mutability. We should probably try to add it back. Add a few to-do style comments. Search for "todo!" and "PORTING". Co-authored-by: Xiretza <xiretza@xiretza.xyz> (complete, wildcard, expand, history, history/file) Co-authored-by: Henrik Hørlück Berg <36937807+henrikhorluck@users.noreply.github.com> (builtins/set)
2023-10-09 05:22:27 +08:00
#![allow(clippy::box_default)]
#![allow(clippy::collapsible_if)]
#![allow(clippy::comparison_chain)]
Silence some more clippy lints bool_assert_comparison is stupid, the reason they give is "it's shorter". Well, `assert!(!foo)` is nowhere near as readable as `assert_eq!(foo, false)` because of the ! noise from the macro. Uninlined format args is a stupid lint that Rust actually walked back when they made it an official warning because you still have to use a mix of inlined and un-inlined format args (the latter of which won't complain) since only idents can be inlined.
2023-03-05 14:54:17 +08:00
#![allow(clippy::derivable_impls)]
Sort clippy lints
2023-10-09 01:08:46 +08:00
#![allow(clippy::field_reassign_with_default)]
Fix some clippy lints
2023-12-30 04:17:22 +08:00
#![allow(clippy::get_first)]
Port execution Drop support for history file version 1. ParseExecutionContext no longer contains an OperationContext because in my first implementation, ParseExecutionContext didn't have interior mutability. We should probably try to add it back. Add a few to-do style comments. Search for "todo!" and "PORTING". Co-authored-by: Xiretza <xiretza@xiretza.xyz> (complete, wildcard, expand, history, history/file) Co-authored-by: Henrik Hørlück Berg <36937807+henrikhorluck@users.noreply.github.com> (builtins/set)
2023-10-09 05:22:27 +08:00
#![allow(clippy::if_same_then_else)]
Sort clippy lints
2023-10-09 01:08:46 +08:00
#![allow(clippy::manual_is_ascii_check)]
Port execution Drop support for history file version 1. ParseExecutionContext no longer contains an OperationContext because in my first implementation, ParseExecutionContext didn't have interior mutability. We should probably try to add it back. Add a few to-do style comments. Search for "todo!" and "PORTING". Co-authored-by: Xiretza <xiretza@xiretza.xyz> (complete, wildcard, expand, history, history/file) Co-authored-by: Henrik Hørlück Berg <36937807+henrikhorluck@users.noreply.github.com> (builtins/set)
2023-10-09 05:22:27 +08:00
#![allow(clippy::mut_from_ref)]
Sort clippy lints
2023-10-09 01:08:46 +08:00
#![allow(clippy::needless_return)]
Port parse_util Except for the indent visitor bits. Tests for parse_util_detect_errors* are not ported yet because they depend on expand.h (and operation_context.h which depends on env.h).
2023-04-18 18:53:32 +08:00
#![allow(clippy::option_map_unit_fn)]
Silence some more clippy lints They are at odds with some direct translations.
2023-04-22 02:56:15 +08:00
#![allow(clippy::ptr_arg)]
Port execution Drop support for history file version 1. ParseExecutionContext no longer contains an OperationContext because in my first implementation, ParseExecutionContext didn't have interior mutability. We should probably try to add it back. Add a few to-do style comments. Search for "todo!" and "PORTING". Co-authored-by: Xiretza <xiretza@xiretza.xyz> (complete, wildcard, expand, history, history/file) Co-authored-by: Henrik Hørlück Berg <36937807+henrikhorluck@users.noreply.github.com> (builtins/set)
2023-10-09 05:22:27 +08:00
#![allow(clippy::redundant_slicing)]
#![allow(clippy::too_many_arguments)]
Sort clippy lints
2023-10-09 01:08:46 +08:00
#![allow(clippy::uninlined_format_args)]
Port execution Drop support for history file version 1. ParseExecutionContext no longer contains an OperationContext because in my first implementation, ParseExecutionContext didn't have interior mutability. We should probably try to add it back. Add a few to-do style comments. Search for "todo!" and "PORTING". Co-authored-by: Xiretza <xiretza@xiretza.xyz> (complete, wildcard, expand, history, history/file) Co-authored-by: Henrik Hørlück Berg <36937807+henrikhorluck@users.noreply.github.com> (builtins/set)
2023-10-09 05:22:27 +08:00
#![allow(clippy::unnecessary_to_owned)]
#![allow(clippy::unnecessary_unwrap)]
Initial Rust commit
2023-01-15 06:56:24 +08:00
Add BUILD_VERSION to lib.rs In CMake this used a `version` file in the CARGO_MANIFEST_DIR, but relying on that is problematic due to change-detection, as if we add `cargo-rerun-if-changed:version`, cargo would rerun every time if the file does not exist, since cargo would expect the file to be generated by the build-script. We could generate it, but that relies on the output of `git describe`, whose dependencies we can only limit to anything in the `.git`-folder, again causing unnecessary build-script runs. Instead, this reads the `FISH_BUILD_VERSION`-env-variable at compile time instead of the `version`-file, and falls back to calling git-describe through the `git_version`-proc-macro. We thus do not need to deal with extraneous build-script running.
2023-08-20 21:48:41 +08:00
pub const BUILD_VERSION: &str = match option_env!("FISH_BUILD_VERSION") {
Some(v) => v,
None => git_version::git_version!(args = ["--always", "--dirty=-dirty"], fallback = "unknown"),
};
Port ASSERT_SORTED_BY_NAME to Rust
2023-02-26 23:34:03 +08:00
#[macro_use]
Use Rust for executables Use Rust for executables Drops the C++ entry points and restructures the Rust package into a library and three binary crates. Renames the fish-rust package to fish. At least on Ubuntu, "fish_indent" is built before "fish". Make sure export CURSES_LIBRARY_LIST to all binaries to make sure that "cached-curses-libnames" is populated. Closes #10198
2024-01-12 20:08:41 +08:00
pub mod common;
lib.rs: group common.rs before other modules, because it exports macros This allows us to keep the next group sorted.
2023-04-02 22:42:59 +08:00
Use Rust for executables Use Rust for executables Drops the C++ entry points and restructures the Rust package into a library and three binary crates. Renames the fish-rust package to fish. At least on Ubuntu, "fish_indent" is built before "fish". Make sure export CURSES_LIBRARY_LIST to all binaries to make sure that "cached-curses-libnames" is populated. Closes #10198
2024-01-12 20:08:41 +08:00
pub mod abbrs;
pub mod ast;
pub mod autoload;
pub mod builtins;
pub mod color;
pub mod complete;
pub mod curses;
pub mod editable_line;
pub mod env;
pub mod env_dispatch;
pub mod env_universal_common;
pub mod event;
pub mod exec;
pub mod expand;
pub mod fallback;
pub mod fd_monitor;
pub mod fd_readable_set;
pub mod fds;
pub mod flog;
pub mod fork_exec;
pub mod function;
pub mod future;
pub mod future_feature_flags;
pub mod global_safety;
pub mod highlight;
pub mod history;
pub mod input;
pub mod input_common;
pub mod io;
pub mod job_group;
pub mod kill;
Rename compat.rs to libc.rs Matches Rust convention better.
2024-01-08 02:18:15 +08:00
#[allow(non_snake_case)]
Use Rust for executables Use Rust for executables Drops the C++ entry points and restructures the Rust package into a library and three binary crates. Renames the fish-rust package to fish. At least on Ubuntu, "fish_indent" is built before "fish". Make sure export CURSES_LIBRARY_LIST to all binaries to make sure that "cached-curses-libnames" is populated. Closes #10198
2024-01-12 20:08:41 +08:00
pub mod libc;
pub mod locale;
pub mod nix;
pub mod null_terminated_array;
pub mod operation_context;
pub mod output;
pub mod pager;
pub mod parse_constants;
pub mod parse_execution;
pub mod parse_tree;
pub mod parse_util;
pub mod parser;
pub mod parser_keywords;
pub mod path;
pub mod pointer;
pub mod print_help;
pub mod proc;
pub mod re;
pub mod reader;
pub mod reader_history_search;
pub mod redirection;
pub mod screen;
pub mod signal;
pub mod termsize;
pub mod threads;
pub mod timer;
pub mod tinyexpr;
pub mod tokenizer;
pub mod topic_monitor;
pub mod trace;
pub mod universal_notifier;
pub mod util;
pub mod wait_handle;
pub mod wchar;
pub mod wchar_ext;
pub mod wcstringutil;
pub mod wgetopt;
pub mod widecharwidth;
pub mod wildcard;
pub mod wutil;
Implement builtin_wait in Rust This implements builtin_wait in Rust.
2023-01-16 11:52:08 +08:00
Turn FFI tests into native Rust tests Keep running tests serially to avoid breaking assumptions. I think many of these tests can run in parallel and/or don't need test_init(). Use the safe variant everywhere, to get it done faster.
2024-01-04 03:57:28 +08:00
#[cfg(test)]
Port fd_monitor tests to rust This shows some of the ugliness of the rust borrow checker when it comes to safely implementing any sort of recursive access and the need to be overly explicit about which types are actually used across threads and which aren't. We're forced to use an `Arc` for `ItemMaker` (née `item_maker_t`) because there's no other way to make it clear that its lifetime will last longer than the FdMonitor's. But once we've created an `Arc<T>` we can't call `Arc::get_mut()` to get an `&mut T` once we've created even a single weak reference to the Arc (because that weak ref could be upgraded to a strong ref at any time). This means we need to finish configuring any non-atomic properties (such as `ItemMaker::always_exit`) before we initialize the callback (which needs an `Arc<ItemMaker>` to do its thing). Because rust doesn't like self-referential types and because of the fact that we now need to create both the `ItemMaker` and the `FdMonitorItem` separately before we set the callback (at which point it becomes impossible to get a mutable reference to the `ItemMaker`), `ItemMaker::item` is dropped from the struct and we instead have the "constructor" for `ItemMaker` take a reference to an `FdMonitor` instance and directly add itself to the monitor's set, meaning we don't need to move the item out of the `ItemMaker` in order to add it to the `FdMonitor` set later.
2023-03-05 13:49:17 +08:00
mod tests;
Reference in New Issue Copy Permalink