fish-shell/src/builtin_eval.h

// Prototypes for executing builtin_eval function.
#ifndef FISH_BUILTIN_EVAL_H
#define FISH_BUILTIN_EVAL_H

#include "maybe.h"

class parser_t;
struct io_streams_t;

maybe_t<int> builtin_eval(parser_t &parser, io_streams_t &streams, const wchar_t **argv);
#endif
Re-implement `eval` as a regular builtin I did not realize builtins could safely call into the parser and inject jobs during execution. This is much cleaner than hacking around the required shape of a plain_statement. 2019-04-12 06:53:08 -05:00			`// Prototypes for executing builtin_eval function.`
			`#ifndef FISH_BUILTIN_EVAL_H`
			`#define FISH_BUILTIN_EVAL_H`

Change builtins to return maybe_t<int> instead of int 2020-07-18 10:25:43 -07:00			`#include "maybe.h"`

Re-implement `eval` as a regular builtin I did not realize builtins could safely call into the parser and inject jobs during execution. This is much cleaner than hacking around the required shape of a plain_statement. 2019-04-12 06:53:08 -05:00			`class parser_t;`
			`struct io_streams_t;`

Make arguments to builtins const Prior to this change, builtins would take their arguments as `wchar_t `. This implies that the order of the arguments may be changed (which is true, `wgetopter` does so) but also that the strings themselves may be changed, which no builtin should do. Switch them all to take `const wchar_t ` instead: now the arguments may be rearranged but their contents may no longer be modified. 2021-02-13 18:41:09 -08:00			`maybe_t<int> builtin_eval(parser_t &parser, io_streams_t &streams, const wchar_t **argv);`
Re-implement `eval` as a regular builtin I did not realize builtins could safely call into the parser and inject jobs during execution. This is much cleaner than hacking around the required shape of a plain_statement. 2019-04-12 06:53:08 -05:00			`#endif`