fish-shell/.clang-tidy

---
Checks:          'clang-diagnostic-*,clang-analyzer-*,-clang-analyzer-valist.Uninitialized,cert-*,performance-*,portability-*,-modernize-use-auto,modernize-loop-convert,modernize-use-bool-literals,modernize-use-using,hicpp-uppercase-literal-suffix,readability-make-member-function-const,readability-redundant-string-init,readability-inconsistent-declaration-parameter-name,readability-redundant-access-specifiers,-performance-noexcept-move-constructor,-cert-dcl37-c,-cert-dcl50-cpp,-cert-dcl51-cpp,-cert-str34-c,-cert-env33-c'
WarningsAsErrors: ''
HeaderFilterRegex: ''
AnalyzeTemporaryDtors: false
FormatStyle:     File
CheckOptions:
  - key:             cert-dcl16-c.NewSuffixes
    value:           'L;LL;LU;LLU'
  - key:             cert-oop54-cpp.WarnOnlyIfThisHasSuspiciousField
    value:           '0'
  - key:             modernize-loop-convert.MinConfidence
    value:           'risky'
  - key:             modernize-use-auto.RemoveStars
    value:           '1'
...
Add a clang-tidy file. 2020-03-31 21:54:21 +08:00			`---`
Disable some clang-tidy lints with false positives One warns about using system() which we only use in test code (we're all adults): src/fish_tests.cpp:2015:9: warning: calling 'system' uses a command processor [cert-env33-c] if (system("mkdir -p test/fish_expand_test/bb/")) err(L"mkdir failed"); Some conversion warnings that don't seem very useful: src/input_common.cpp:181:20: warning: 'signed char' to 'wint_t' (aka 'unsigned int') conversion; consider casting to 'unsigned char' first. [cert-str34-c] wint_t b = evt.get_char(); Warning about varargs doesn't make sense, because some of our functions use std::vswprintf() internally. src/ast.cpp:486:10: warning: do not define a C-style variadic function; consider using a function parameter pack or currying instead [cert-dcl50-cpp] void internal_error(const char func, const wchar_t fmt, ...) const { Finally, what seems like a false positive; "va" is initialized by va_copy: src/common.cpp:468:18: warning: Function 'vswprintf' is called with an uninitialized va_list argument [clang-analyzer-valist.Uninitialized] status = std::vswprintf(buff, size / sizeof(wchar_t), format, va); 2020-12-25 17:04:02 +08:00			Checks: 'clang-diagnostic-,clang-analyzer-,-clang-analyzer-valist.Uninitialized,cert-,performance-,portability-*,-modernize-use-auto,modernize-loop-convert,modernize-use-bool-literals,modernize-use-using,hicpp-uppercase-literal-suffix,readability-make-member-function-const,readability-redundant-string-init,readability-inconsistent-declaration-parameter-name,readability-redundant-access-specifiers,-performance-noexcept-move-constructor,-cert-dcl37-c,-cert-dcl50-cpp,-cert-dcl51-cpp,-cert-str34-c,-cert-env33-c'
Add a clang-tidy file. 2020-03-31 21:54:21 +08:00			`WarningsAsErrors: ''`
			`HeaderFilterRegex: ''`
			`AnalyzeTemporaryDtors: false`
			`FormatStyle: File`
			`CheckOptions:`
			`- key: cert-dcl16-c.NewSuffixes`
			`value: 'L;LL;LU;LLU'`
			`- key: cert-oop54-cpp.WarnOnlyIfThisHasSuspiciousField`
			`value: '0'`
[clang-tidy] use range based loop Found with modernize-loop-convert Signed-off-by: Rosen Penev <rosenp@gmail.com> 2020-04-03 07:45:11 +08:00			`- key: modernize-loop-convert.MinConfidence`
			`value: 'risky'`
[clang-tidy] use auto when casting Found with modernize-use-auto Signed-off-by: Rosen Penev <rosenp@gmail.com> 2020-04-03 07:04:04 +08:00			`- key: modernize-use-auto.RemoveStars`
			`value: '1'`
Add a clang-tidy file. 2020-03-31 21:54:21 +08:00			`...`