Make tests usable with path with spaces
This is somewhat subtle:
The #RUN line in a littlecheck file will be run by a posix shell,
which means the substitutions will also be mangled by it.
Now, we *have* shell-quoted them, but unfortunately what we need is to
quote them for inside a pre-existing layer of quotes, e.g.
# RUN: fish -C 'set -g fish %fish'
here, %fish can't be replaced with `'path with spaces/fish'`, because
that ends up as
# RUN: fish -C 'set -g fish 'path with spaces/fish''
which is just broken.
So instead, we pass it as a variable to that fish:
# RUN: fish=%fish fish...
In addition, we need to not mangle the arguments in our test_driver.
For that, because we insist on posix shell, which has only one array,
and we source a file, we *need* to stop having that file use
arguments.
Which is okay - test_env.sh could previously be used to start a test,
and now it no longer can because that is test_*driver*.sh's job.
For the interactive tests, it's slightly different:
pexpect.spawn(foo) is sensitive to shell metacharacters like space.
So we shell-quote it.
But if you pass any args to pexpect.spawn, it no longer uses a shell,
and so we cannot shell-quote it.
There could be a better way to fix this?
2024-12-28 03:54:43 +08:00
|
|
|
# RUN: fish=%fish %fish %s
|
2023-10-07 00:15:25 +08:00
|
|
|
|
2020-03-10 02:36:12 +08:00
|
|
|
exec cat <nosuchfile
|
2020-02-08 17:38:11 +08:00
|
|
|
#CHECKERR: warning: An error occurred while redirecting file 'nosuchfile'
|
2021-11-20 04:11:28 +08:00
|
|
|
#CHECKERR: warning: Path 'nosuchfile' does not exist
|
2020-02-08 17:38:11 +08:00
|
|
|
echo "failed: $status"
|
|
|
|
#CHECK: failed: 1
|
2020-03-10 02:36:12 +08:00
|
|
|
not exec cat <nosuchfile
|
2020-02-08 17:38:11 +08:00
|
|
|
#CHECKERR: warning: An error occurred while redirecting file 'nosuchfile'
|
2021-11-20 04:11:28 +08:00
|
|
|
#CHECKERR: warning: Path 'nosuchfile' does not exist
|
2020-02-08 17:38:11 +08:00
|
|
|
echo "neg failed: $status"
|
|
|
|
#CHECK: neg failed: 0
|
2020-09-25 22:44:02 +08:00
|
|
|
|
2023-10-07 00:15:25 +08:00
|
|
|
# See that variable overrides are applied to exec'd processes
|
2025-01-20 01:47:28 +08:00
|
|
|
# Match the entire line because github actions passes commit messages in the environment,
|
|
|
|
# so any message that includes "foo=bar" would also be matched.
|
|
|
|
$fish --no-config -c 'foo=bar exec env' | grep '^foo=bar$'
|
2023-10-07 00:15:25 +08:00
|
|
|
# CHECK: foo=bar
|
|
|
|
|
2020-09-25 22:44:02 +08:00
|
|
|
# This needs to be last, because it actually runs exec.
|
2020-03-10 02:36:12 +08:00
|
|
|
exec cat </dev/null
|
2020-02-08 17:38:11 +08:00
|
|
|
echo "not reached"
|