github-mirror/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2025-02-19 17:25:15 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity
bffbf0cd57
fish-shell/tests/checks/tmux-autosuggestion.fish

48 lines
1.2 KiB
Fish
Raw Normal View History

Clean up the accept-autosuggestion code path a little bit It's still a bit too complex unfortunately.
2024-11-14 19:20:47 +08:00
#RUN: %fish %s
#REQUIRES: command -v tmux
isolated-tmux-start
isolated-tmux send-keys 'echo "foo bar baz"' Enter C-l
isolated-tmux send-keys 'echo '
tmux-sleep
isolated-tmux send-keys M-Right
isolated-tmux capture-pane -p
# CHECK: prompt 1> echo "foo bar baz"
tmux-sleep
Apply autosuggestions from completions also if cursor is not at EOL Before 1c4e5cadf2 (Autosuggestions in multi-line command lines, 2024-12-15), the completion code path in the autosuggestion performer used to do something weird: it used to request completions for the entire command line (with the implied cursor at end) but try to apply the same completion at the actual cursor. That commit changed this to request completions only up to the cursor position, which could in theory make us produce valid completions even if the cursor is not at end of the line. However, that doesn't really work since autosuggestions can only be rendered at the end of the line. And the worst of it, that commit tries to compute line_at_cursor(&full_line, search_string_range.end) which crashes as out-of-bounds if the completion needs to replace the token (like a case-correcting completion does). Let's apply completions to the end, matching how autosuggestions work in general.
2025-01-03 19:15:55 +08:00
touch COMPL
# Regression test.
isolated-tmux send-keys C-u C-l ': sometoken' M-b c
tmux-sleep
isolated-tmux capture-pane -p
# CHECK: prompt 1> : csometoken
# Test that we get completion autosuggestions also when the cursor is not at EOL.
isolated-tmux send-keys C-u 'complete nofilecomp -f' Enter C-l 'nofilecomp ./CO' C-a M-d :
tmux-sleep
isolated-tmux capture-pane -p
# CHECK: prompt 2> : ./COMPL
Restore autosuggestion after corrected typo Backspace signals that the user is not happy with the commandline, and by extension the autosuggestion. For this reason, backspace suppresses autosuggestions until the next text insertion. However if I 1. type something that has an autosuggestion 2. type *one* wrong letter (removing the autosuggestion) 3. type backspace backspace does not visibly suppress any autosuggestion but rhater signal that the user wants to go back to the previous state of the commandline, which does have an autosuggestion. Enable this scenario by caching the autosuggestion when it's invalidated. On certain edits that make the cached autosuggestion valid again, restore it from the cache. Currently, only do this up to a single backspace. Could extend that in future. This implementation is really bad.. but it's a start. Weirdly, it does not restore the cache on undo; but that's inconsequential because undo doesn't suppress autosuggestion as of today. Closes #3549
2025-01-11 00:59:22 +08:00
isolated-tmux send-keys C-u C-k C-l ': ./CO'
tmux-sleep
isolated-tmux send-keys A C-h
tmux-sleep
isolated-tmux capture-pane -p
# CHECK: prompt 2> : ./COMPL
Fix regression causing missing autosuggestions after ( Commit 4f3d6427ce (Fix regression causing crash in "commandline -j", 2025-01-12) wasn't quite right; it mishandles the edge case where the current process has no token, fix that.
2025-01-14 05:20:29 +08:00
Stop saving autosuggestions that we can't restore Sorry, commit 51adba6ee0 (Restore autosuggestion after corrected typo, 2025-01-10) was pushed too early. One issue is that it saves autosuggestions also when we edit in the middle, where we can't restore it. We'd still restore it in some cases, even though it doesn't apply. This breaks invariants that may cause various problems when interacting with the autosuggestion. Fix it by only saving the autosuggestion when we will be able to restore it correctly.
2025-01-17 16:33:24 +08:00
isolated-tmux send-keys C-u 'ech {' Left Left
tmux-sleep
isolated-tmux send-keys o C-e C-h 'still alive' Enter
tmux-sleep
isolated-tmux capture-pane -p
# CHECK: prompt {{\d+}}> echo still alive
# CHECK: still alive
# CHECK: prompt {{\d+}}>
Fix regression causing missing autosuggestions after ( Commit 4f3d6427ce (Fix regression causing crash in "commandline -j", 2025-01-12) wasn't quite right; it mishandles the edge case where the current process has no token, fix that.
2025-01-14 05:20:29 +08:00
isolated-tmux send-keys C-u 'echo (echo)' Enter
isolated-tmux send-keys C-l 'echo ('
tmux-sleep
isolated-tmux capture-pane -p
Stop saving autosuggestions that we can't restore Sorry, commit 51adba6ee0 (Restore autosuggestion after corrected typo, 2025-01-10) was pushed too early. One issue is that it saves autosuggestions also when we edit in the middle, where we can't restore it. We'd still restore it in some cases, even though it doesn't apply. This breaks invariants that may cause various problems when interacting with the autosuggestion. Fix it by only saving the autosuggestion when we will be able to restore it correctly.
2025-01-17 16:33:24 +08:00
# CHECK: prompt {{\d+}}> echo (echo)
Reference in New Issue Copy Permalink