fish-shell/tests/checks/check-completions.fish

#RUN: fish=%fish %fish %s
# disable on CI ASAN because it's suuuper slow
#REQUIRES: test -z "$FISH_CI_SAN"
# Test all completions where the command exists

# No output is good output
for f in $__fish_data_dir/completions/*.fish
    if type -q (string replace -r '.*/([^/]+).fish' '$1' $f)
        set -l out (source $f 2>&1 | string collect)
        test -n "$out"
        and echo -- OUTPUT from $f: $out
    end
end
Make tests usable with path with spaces This is somewhat subtle: The #RUN line in a littlecheck file will be run by a posix shell, which means the substitutions will also be mangled by it. Now, we have shell-quoted them, but unfortunately what we need is to quote them for inside a pre-existing layer of quotes, e.g. # RUN: fish -C 'set -g fish %fish' here, %fish can't be replaced with `'path with spaces/fish'`, because that ends up as # RUN: fish -C 'set -g fish 'path with spaces/fish'' which is just broken. So instead, we pass it as a variable to that fish: # RUN: fish=%fish fish... In addition, we need to not mangle the arguments in our test_driver. For that, because we insist on posix shell, which has only one array, and we source a file, we need to stop having that file use arguments. Which is okay - test_env.sh could previously be used to start a test, and now it no longer can because that is test_driver.sh's job. For the interactive tests, it's slightly different: pexpect.spawn(foo) is sensitive to shell metacharacters like space. So we shell-quote it. But if you pass any args to pexpect.spawn, it no longer uses a shell, and so we cannot shell-quote it. There could be a better way to fix this? 2024-12-28 03:54:43 +08:00			`#RUN: fish=%fish %fish %s`
tests: Disable some slow tests under ASAN These take over two minutes under ASAN (like ~40 seconds without, so they aren't quick to begin with), and don't really give any additional insight. So we skip them to save time 2024-04-26 03:52:13 +08:00			`# disable on CI ASAN because it's suuuper slow`
			`#REQUIRES: test -z "$FISH_CI_SAN"`
Add a test that runs all available completions Meaning completions where we have the command. No completion should be printing anything when sourced. This could have prevented #8896 2022-04-21 23:19:36 +08:00			`# Test all completions where the command exists`

			`# No output is good output`
			`for f in $__fish_data_dir/completions/*.fish`
Store output Now we can explain which file printed the error 2022-04-21 23:28:55 +08:00			`if type -q (string replace -r '.*/([^/]+).fish' '$1' $f)`
source the files instead This might be a bit faster running under TSAN, otherwise it takes > 400 seconds on Github Actions. If this doesn't work we need to disable it for TSAN. 2022-04-21 23:40:25 +08:00			`set -l out (source $f 2>&1 \| string collect)`
Store output Now we can explain which file printed the error 2022-04-21 23:28:55 +08:00			`test -n "$out"`
			`and echo -- OUTPUT from $f: $out`
Add a test that runs all available completions Meaning completions where we have the command. No completion should be printing anything when sourced. This could have prevented #8896 2022-04-21 23:19:36 +08:00			`end`
			`end`