github-mirror/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2024-11-24 20:24:19 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity
f59cdfaa8d
fish-shell/tests/checks/eval.fish

85 lines
1.7 KiB
Fish
Raw Normal View History

tests: filter control sequences only when interactive This demonstrates that we only write control sequences when interactive.
2024-04-12 18:19:32 +08:00
# RUN: %fish %s
Port eval tests to littlecheck
2019-07-03 18:54:42 +08:00
# Regression test for issue #4443
eval set -l previously_undefined foo
echo $previously_undefined
# CHECK: foo
# Test redirection
eval "echo you can\\'t see this 1>&2" 2>/dev/null
# Test return statuses
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-14 03:34:22 +08:00
false
eval true
echo $status
Port eval tests to littlecheck
2019-07-03 18:54:42 +08:00
# CHECK: 0
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-14 03:34:22 +08:00
false
eval false
echo $status
Port eval tests to littlecheck
2019-07-03 18:54:42 +08:00
# CHECK: 1
# Test return status in case of parsing error
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-14 03:34:22 +08:00
false
eval "("
echo $status
Rationalize $status and errors Prior to this fix, fish was rather inconsistent in when $status gets set in response to an error. For example, a failed expansion like "$foo[" would not modify $status. This makes the following inter-related changes: 1. String expansion now directly returns the value to set for $status on error. The value is always used. 2. parser_t::eval() now directly returns the proc_status_t, which cleans up a lot of call sites. 3. We expose a new function exec_subshell_for_expand() which ignores $status but returns errors specifically related to subshell expansion. 4. We reify the notion of "expansion breaking" errors. These include command-not-found, expand syntax errors, and others. The upshot is we are more consistent about always setting $status on errors.
2020-01-24 09:34:46 +08:00
# CHECK: 123
eval tests: Fix path I tested this manually (`littlecheck.py -s fish=fish tests/checks/eval.fish`) from the base directory, which means I got "tests/checks/eval", while the real test gets "checks/eval". I then reran `make test_fishscript`, but that didn't pull in the updated test - we should really handle that better.
2019-07-03 21:14:49 +08:00
# CHECKERR: {{.*}}checks/eval.fish (line {{\d+}}): Unexpected end of string, expecting ')'
Port eval tests to littlecheck
2019-07-03 18:54:42 +08:00
# CHECKERR: (
# CHECKERR: ^
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-14 03:34:22 +08:00
false
eval '""'
echo $status
Rationalize $status and errors Prior to this fix, fish was rather inconsistent in when $status gets set in response to an error. For example, a failed expansion like "$foo[" would not modify $status. This makes the following inter-related changes: 1. String expansion now directly returns the value to set for $status on error. The value is always used. 2. parser_t::eval() now directly returns the proc_status_t, which cleans up a lot of call sites. 3. We expose a new function exec_subshell_for_expand() which ignores $status but returns errors specifically related to subshell expansion. 4. We reify the notion of "expansion breaking" errors. These include command-not-found, expand syntax errors, and others. The upshot is we are more consistent about always setting $status on errors.
2020-01-24 09:34:46 +08:00
# CHECK: 123
eval tests: Fix path I tested this manually (`littlecheck.py -s fish=fish tests/checks/eval.fish`) from the base directory, which means I got "tests/checks/eval", while the real test gets "checks/eval". I then reran `make test_fishscript`, but that didn't pull in the updated test - we should really handle that better.
2019-07-03 21:14:49 +08:00
# CHECKERR: {{.*}}checks/eval.fish (line {{\d+}}): The expanded command was empty.
Port eval tests to littlecheck
2019-07-03 18:54:42 +08:00
# CHECKERR: ""
Add more tests These were correct, but littlecheck escapes quotes!
2022-08-12 00:20:40 +08:00
# CHECKERR: ^^
Port eval tests to littlecheck
2019-07-03 18:54:42 +08:00
function empty
end
# Regression tests for issue #5692
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-14 03:34:22 +08:00
false
eval
Port eval tests to littlecheck
2019-07-03 18:54:42 +08:00
echo blank eval: $status # 0
# CHECK: blank eval: 0
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-14 03:34:22 +08:00
false
eval ""
Port eval tests to littlecheck
2019-07-03 18:54:42 +08:00
echo empty arg eval: $status # 0
# CHECK: empty arg eval: 0
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-14 03:34:22 +08:00
false
eval empty
Port eval tests to littlecheck
2019-07-03 18:54:42 +08:00
echo empty function eval $status # 0
# CHECK: empty function eval 0
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-14 03:34:22 +08:00
false
eval "begin; end;"
Port eval tests to littlecheck
2019-07-03 18:54:42 +08:00
echo empty block eval: $status # 0
# CHECK: empty block eval: 0
source: Escape filenames in errors Otherwise this would look weird if you had, say, a tab in there. See #7716. (note that this doesn't handle e.g. zero-width-joiners, because those aren't currently escaped. we might want to add an escape mode for unprintable characters, but for combining codepoints that's tricky!)
2021-02-16 00:06:43 +08:00
source /banana/\t/foo
# CHECKERR: source: Error encountered while sourcing file '/banana/\t/foo':
# CHECKERR: source: No such file or directory
Make `eval` a reserved keyword Like `set` and `read` before it, `eval` can be used to set variables, and so it can't be shadowed by a function without loss of functionality. So this forbids it. Incidentally, this means we will no longer try to autoload an `eval.fish` file that's left over from an old version, which would have helped with #8963.
2022-05-19 00:47:10 +08:00
# See that eval can't be defined as a function
function eval
builtin eval $argv
end
# CHECKERR: checks/eval.fish (line {{\d+}}): function: eval: cannot use reserved keyword as function name
# CHECKERR: function eval
# CHECKERR: ^
function evil --no-scope-shadowing
eval $argv
end
# And this is why we do this: `eval` *can't* be cleanly shadowed with a function,
# because that would always introduce a new block or at the very least clobber $argv.
eval set -l argv this works
echo $argv
# CHECK: this works
evil set -l argv this does not
echo $argv
# CHECK: this works
Reference in New Issue Copy Permalink