github-mirror/fish-shell
github-mirror/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2025-03-11 12:55:27 +08:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Mark needs_keepalive more often for WSL

Browse Source 
Have WSL use a keepalive whenever the first process is external.
This works around the fact that WSL prohibits setting an exited
process as the group leader.
This commit is contained in:
ridiculousfish 2017-12-24 16:48:00 -08:00
parent cef39cdcc0
commit 1b1fd5ab9b
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/exec.cpp
View File

@ -576,6 +576,12 @@ void exec_job(parser_t &parser, job_t *j) {
} }
} }
// When running under WSL, create a keepalive process unconditionally if our first process is external.
// This is because WSL does not permit joining the pgrp of an exited process.
// (see https://github.com/Microsoft/WSL/issues/2786), also fish PR #4676
if (j->processes.front()->type == EXTERNAL && is_windows_subsystem_for_linux())
needs_keepalive = true;
if (needs_keepalive) { if (needs_keepalive) {
// Call fork. No need to wait for threads since our use is confined and simple. // Call fork. No need to wait for threads since our use is confined and simple.
keepalive.pid = execute_fork(false); keepalive.pid = execute_fork(false);