github-mirror/fish-shell
github-mirror/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2025-02-26 11:30:55 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Work around false positive RESOURCE_LEAK in coverity scan

Browse Source 
Fixes defect number 7520322
This commit is contained in:
Mahmoud Al-Qudsi 2018-02-08 16:59:38 -06:00
parent 82b7e6de69
commit 3083e0ea80
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/common.cpp
View File

@ -313,7 +313,10 @@ char *wcs2str(const wchar_t *in) {
// Here we probably allocate a buffer probably much larger than necessary. // Here we probably allocate a buffer probably much larger than necessary.
char *out = (char *)malloc(MAX_UTF8_BYTES * wcslen(in) + 1); char *out = (char *)malloc(MAX_UTF8_BYTES * wcslen(in) + 1);
assert(out); assert(out);
return wcs2str_internal(in, out); //Instead of returning the return value of wcs2str_internal, return `out` directly.
//This eliminates false warnings in coverity about resource leaks.
wcs2str_internal(in, out);
return out;
} }
char *wcs2str(const wcstring &in) { return wcs2str(in.c_str()); } char *wcs2str(const wcstring &in) { return wcs2str(in.c_str()); }