github-mirror/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2024-11-23 03:24:47 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Work around i586 wcstod test failure

Browse Source 
As documented in #10474, there are issues with 64-bit floating point rounding
under x86 targets without SSE2 extensions, where x87 floating point math causes
imprecise results.

Document the shortcoming and provide some version of the test that passes
regardless of architecture.
This commit is contained in:
Mahmoud Al-Qudsi 2024-05-04 20:18:31 -05:00
parent a99a7e65e7
commit 4d58a31670
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/wutil/wcstod.rs
View File

@ -572,7 +572,15 @@ mod test {
fn test_sep(input: &str, val: Result<f64, Error>, decimalsep: char) {
let mut consumed = 0;
let result = wcstod(input, decimalsep, &mut consumed);
assert_eq!(result, val);
// There are fundamental issues with f64 accuracy under x87. See #10474 and https://github.com/rust-lang/rust/issues/114479
if cfg!(all(target_arch = "x86", not(target_feature = "sse2"))) {
assert_eq!(result, val);
} else {
// Make sure the result is at least somewhat sane. We might need to change f64::EPSILON
// to a bigger value if we are testing the result after operations that have multiple
// opportunities for rounding loss in the future.
assert!(result == val || (result.unwrap() - val.unwrap()).abs() < f64::EPSILON);
}
if result.is_ok() {
assert_eq!(consumed, input.chars().count());
assert_eq!(