diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 47b888e52..ab3c1b2ff 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -108,35 +108,39 @@ jobs: run: | make test - ubuntu-threadsan: + # Our clang++ tsan builds are not recognizing safe rust patterns (such as the fact that Drop + # cannot be called while a thread is using the object in question). Rust has its own way of + # running TSAN, but for the duration of the port from C++ to Rust, we'll keep this disabled. - runs-on: ubuntu-latest - - steps: - - uses: actions/checkout@v3 - - name: SetupRust - uses: ATiltedTree/setup-rust@v1 - with: - rust-version: beta - - name: Install deps - run: | - sudo apt install gettext libncurses5-dev libpcre2-dev python3-pip tmux - sudo pip3 install pexpect - - name: cmake - env: - FISH_CI_SAN: 1 - CC: clang - CXX: clang++ - CXXFLAGS: "-fsanitize=thread" - run: | - mkdir build && cd build - cmake .. - - name: make - run: | - make - - name: make test - run: | - make test + # ubuntu-threadsan: + # + # runs-on: ubuntu-latest + # + # steps: + # - uses: actions/checkout@v3 + # - name: SetupRust + # uses: ATiltedTree/setup-rust@v1 + # with: + # rust-version: beta + # - name: Install deps + # run: | + # sudo apt install gettext libncurses5-dev libpcre2-dev python3-pip tmux + # sudo pip3 install pexpect + # - name: cmake + # env: + # FISH_CI_SAN: 1 + # CC: clang + # CXX: clang++ + # CXXFLAGS: "-fsanitize=thread" + # run: | + # mkdir build && cd build + # cmake .. + # - name: make + # run: | + # make + # - name: make test + # run: | + # make test macos: