github-mirror/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2025-02-01 07:18:30 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix to properly null-terminate export list

Browse Source
This commit is contained in:
ridiculousfish 2012-02-17 11:42:53 -08:00
parent fdef238a83
commit 4fd2531302
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
env.cpp
View File

@ -1667,7 +1667,7 @@ char **env_export_arr( int recalc )
export_func2(vals, &export_buffer );
export_arr = (char **)realloc( export_arr,
sizeof(char *)*(vals.size()) + 4) ; //REVIEW I replaced 1 with 4 because I was getting an invalid write of 4 bytes for export[arr] = 0 below
sizeof(char *)*(1 + vals.size())); //add 1 for null termination
for( i=0; i<export_buffer.used; i++ )
{
@ -1678,7 +1678,7 @@ char **env_export_arr( int recalc )
}
prev_was_null = (export_buffer.buff[i]==0);
}
export_arr[pos]=0; // REVIEW <- This is why I have changed 1 with 4
export_arr[pos]=NULL;
has_changed=0;
}