From 550857ef65dc56a456b528b64b323e1e76a3ef0b Mon Sep 17 00:00:00 2001
From: Aaron Gyes <var.log@icloud.com>
Date: Sun, 1 Jan 2023 19:37:38 -0800
Subject: [PATCH] Remove obsolete lynx bug mitigation

a lynx-internal hash of div.contents collided with em>a which caused
built-in styling to render much of entire pages as emphasized links.

Since switching from doxygen, we haven't had a <div class="contents">
so this workaround is no longer needed.
---
 cmake/Install.cmake       |   2 -
 share/functions/help.fish |   5 --
 share/lynx.lss            | 104 --------------------------------------
 3 files changed, 111 deletions(-)
 delete mode 100644 share/lynx.lss

diff --git a/cmake/Install.cmake b/cmake/Install.cmake
index 75f96716c..6615e17fc 100644
--- a/cmake/Install.cmake
+++ b/cmake/Install.cmake
@@ -158,8 +158,6 @@ install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/user_doc/html/ # Trailing slash is
         DESTINATION ${docdir} OPTIONAL)
 install(FILES CHANGELOG.rst DESTINATION ${docdir})
 
-install(FILES share/lynx.lss DESTINATION ${rel_datadir}/fish/)
-
 # These files are built by cmake/gettext.cmake, but using GETTEXT_PROCESS_PO_FILES's
 # INSTALL_DESTINATION leads to them being installed as ${lang}.gmo, not fish.mo
 # The ${languages} array comes from cmake/gettext.cmake
diff --git a/share/functions/help.fish b/share/functions/help.fish
index a1437cb40..4990d9062 100644
--- a/share/functions/help.fish
+++ b/share/functions/help.fish
@@ -242,11 +242,6 @@ function help --description 'Show help for the fish shell'
         $fish_browser $page_url &
         disown $last_pid >/dev/null 2>&1
     else
-        # Work around lynx bug where <div class="contents"> always has the same formatting as links (unreadable)
-        # by using a custom style sheet. See https://github.com/fish-shell/fish-shell/issues/4170
-        if string match -qr '^lynx' -- $fish_browser
-            set fish_browser $fish_browser -lss={$__fish_data_dir}/lynx.lss
-        end
         $fish_browser $page_url
     end
 end
diff --git a/share/lynx.lss b/share/lynx.lss
deleted file mode 100644
index dcf83f26f..000000000
--- a/share/lynx.lss
+++ /dev/null
@@ -1,104 +0,0 @@
-# Lynx Style Sheet
-# Used as a custom style sheet (LSS) for the Lynx browser to work around some
-# poor defaults. Usage: `lynx -lss=style.lss`
-#
-# The next line (beginning with "em") means: use bold if mono, otherwise
-# brightblue on <defaultbackground> (implicit)
-em:bold:brightblue
-strong:bold:brightred
-b:bold:red
-i:bold:brightblue
-a:bold:green
-img:dim:brown
-fig:normal:gray
-caption:reverse:brown
-hr:normal:yellow
-blockquote:normal:brightblue
-ul:normal:brown
-address:normal:magenta
-title:normal:magenta
-tt:dim:brightmagenta:default
-h1:bold:yellow
-h2:normal:brown
-h3:normal:green
-h4:normal:cyan
-label:normal:magenta
-q:normal:yellow
-small:dim:default
-big:bold:yellow
-sup:bold:yellow
-sub:dim:gray
-lh:bold:yellow
-li:normal:magenta
-code:normal:cyan
-cite:normal:cyan
-
-table:normal:brightcyan
-tr:bold:brown
-td:normal:default
-br:normal:default
-
-# Special styles - not corresponding directly to HTML tags
-#	alert	- status bar, when message begins "Alert".
-#	alink	- active link
-#	normal	- default attributes
-#	status	- status bar
-#	whereis	- whereis search target
-#
-#normal:normal:default:blue
-alink:reverse:yellow
-status:reverse:yellow
-alert:bold:yellow:red
-whereis:reverse+underline:magenta
-# currently not used
-#value:normal:green
-#high:bold:brightmagenta
-forwbackw.arrow:reverse
-
-# Styles with classes - <ul class=red> etc.
-ul.red:underline:brightred
-ul.blue:bold:brightblue
-li.red:reverse:red
-li.blue:bold:blue
-strong.a:bold:black
-/* em.a:reverse:black */
-em.a:bold:bold
-strong.b:bold:white
-em.b:reverse:white
-strong.debug:reverse:green
-font.letter:normal:default
-input.submit:normal:cyan
-tr.baone:bold:yellow
-tr.batwo:bold:green
-tr.bathree:bold:red
-#
-# Special handling for link.
-link:normal:white
-link.green:bold:brightgreen
-link.red:bold:black
-link.blue:bold:white
-link.toc:bold:black:white
-# Special cases for link - the rel or title is appended after the class.
-# <link rel=next class=red href="1">
-link.red.next:bold:red
-link.red.prev:bold:yellow
-link.blue.prev:bold:yellow
-link.blue.next:bold:blue
-link.green.toc:bold:white
-#
-# Define styles that will be used when syntax highlighting is requested
-# (commandline option -prettysrc).
-span.htmlsrc_comment:normal:white
-span.htmlsrc_tag:normal:white
-#If you don't like that the tag name and attribute name are displayed
-#in different colors, comment the following line.
-span.htmlsrc_attrib:normal:cyan
-span.htmlsrc_attrval:normal:magenta
-span.htmlsrc_abracket:normal:white
-span.htmlsrc_entity:normal:white
-##span.htmlsrc_href:
-##span.htmlsrc_entire:
-span.htmlsrc_badseq:normal:red
-span.htmlsrc_badtag:normal:red
-span.htmlsrc_badattr:normal:red
-span.htmlsrc_sgmlspecial:normal:yellow