From 5abd0e46f50449d42febfe343dcfab6efcaa8d74 Mon Sep 17 00:00:00 2001 From: Fabian Boehm Date: Wed, 20 Nov 2024 19:42:16 +0100 Subject: [PATCH] build.rs: Panic if version could not be found We don't want "fish --version" to print "unknown" or any other fake version --- build.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/build.rs b/build.rs index e1ef19a5d..126a4a036 100644 --- a/build.rs +++ b/build.rs @@ -283,7 +283,6 @@ fn get_version(src_dir: &Path) -> String { return version + "-g" + &rev; } } - // TODO: Do we just use the cargo version here? - "unknown".to_string() + panic!("Could not get a version. Either set $FISH_BUILD_VERSION or install git."); }