github-mirror/fish-shell
github-mirror/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2025-03-15 23:22:53 +08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

open: Workaround an xdg-open bug

Browse Source 
If it can't recognize the DE, xdg-open uses a "generic" way of opening
things where it doesn't spawn off a DE-provided utility like kde-open.

This sounds great, but it fails to fork and therefore blocks the
terminal.

So we start it in the background and disown it.

Fixes #7215.
This commit is contained in:
Fabian Homborg 2020-07-21 16:55:57 +02:00
parent 7d2d2c97b2
commit 5b706faa73
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
share/functions/open.fish
View File

@ -24,7 +24,14 @@ if not command -sq open
end
else if type -q -f xdg-open
for i in $argv
xdg-open $i
# In the "generic" path where it doesn't use a helper utility,
# xdg-open fails to fork off, so it blocks the terminal.
xdg-open $i &
# Note: We *need* to pass $last_pid, or it will disown the last *existing* job.
# In case xdg-open forks, that would be whatever else the user has backgrounded.
#
# Yes, this has a (hopefully theoretical) race of the PID being recycled.
disown $last_pid 2>/dev/null
end
else
echo (_ 'No open utility found. Try installing "xdg-open" or "xdg-utils".')