From 5d1ad8de9141e864479e02d54dc93b3e46a26536 Mon Sep 17 00:00:00 2001
From: Rosen Penev <rosenp@gmail.com>
Date: Sat, 21 Dec 2019 13:50:58 -0800
Subject: [PATCH] [clang-tidy] Use std::move

Found with modernize-pass-by-value
---
 src/builtin_string.cpp | 4 ++--
 src/builtin_test.cpp   | 2 +-
 src/complete.cpp       | 4 ++--
 src/expand.cpp         | 6 +++---
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/builtin_string.cpp b/src/builtin_string.cpp
index 7dbf58e58..67f4c38b6 100644
--- a/src/builtin_string.cpp
+++ b/src/builtin_string.cpp
@@ -901,10 +901,10 @@ class literal_replacer_t : public string_replacer_t {
     size_t patlen;
 
    public:
-    literal_replacer_t(const wchar_t *argv0, const wcstring &pattern_, const wchar_t *replacement_,
+    literal_replacer_t(const wchar_t *argv0, wcstring pattern_, const wchar_t *replacement_,
                        const options_t &opts, io_streams_t &streams)
         : string_replacer_t(argv0, opts, streams),
-          pattern(pattern_),
+          pattern(std::move(pattern_)),
           replacement(replacement_),
           patlen(pattern.length()) {}
 
diff --git a/src/builtin_test.cpp b/src/builtin_test.cpp
index 96080af99..3c7485a25 100644
--- a/src/builtin_test.cpp
+++ b/src/builtin_test.cpp
@@ -266,7 +266,7 @@ class combining_expression : public expression {
     const std::vector<token_t> combiners;
 
     combining_expression(token_t tok, range_t where, std::vector<unique_ptr<expression>> exprs,
-                         const std::vector<token_t> &combs)
+                         std::vector<token_t> combs)
         : expression(tok, where), subjects(std::move(exprs)), combiners(std::move(combs)) {
         // We should have one more subject than combiner.
         assert(subjects.size() == combiners.size() + 1);
diff --git a/src/complete.cpp b/src/complete.cpp
index ed144cca5..440dba2e8 100644
--- a/src/complete.cpp
+++ b/src/complete.cpp
@@ -389,9 +389,9 @@ class completer_t {
                                                 const std::vector<tok_t> &args);
 
    public:
-    completer_t(const environment_t &vars, const std::shared_ptr<parser_t> &parser, wcstring c,
+    completer_t(const environment_t &vars, std::shared_ptr<parser_t> parser, wcstring c,
                 completion_request_flags_t f)
-        : vars(vars), parser(parser), cmd(std::move(c)), flags(f) {}
+        : vars(vars), parser(std::move(parser)), cmd(std::move(c)), flags(f) {}
 
     void perform();
 
diff --git a/src/expand.cpp b/src/expand.cpp
index f1334cb41..60ec9c613 100644
--- a/src/expand.cpp
+++ b/src/expand.cpp
@@ -860,9 +860,9 @@ class expander_t {
     expand_result_t stage_home_and_self(wcstring input, std::vector<completion_t> *out);
     expand_result_t stage_wildcards(wcstring path_to_expand, std::vector<completion_t> *out);
 
-    expander_t(const environment_t &vars, const std::shared_ptr<parser_t> &parser,
-               expand_flags_t flags, parse_error_list_t *errors)
-        : vars(vars), parser(parser), flags(flags), errors(errors) {}
+    expander_t(const environment_t &vars, std::shared_ptr<parser_t> parser, expand_flags_t flags,
+               parse_error_list_t *errors)
+        : vars(vars), parser(std::move(parser)), flags(flags), errors(errors) {}
 
    public:
     static expand_result_t expand_string(wcstring input, std::vector<completion_t> *out_completions,