github-mirror/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2025-01-21 12:17:15 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Refactor: pass by value, not reference, to enable move semantics

Browse Source 
clang-tidy wrote:
> warning: passing result of std::move() as a const reference argument;
> no move will actually happen [performance-move-const-arg]
This commit is contained in:
Johannes Altmanninger 2020-12-24 11:00:20 +01:00
parent c890982c90
commit 69a9785f50
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/reader.cpp
View File

@ -643,8 +643,7 @@ class reader_data_t : public std::enable_shared_from_this<reader_data_t> {
/// Erase @length characters starting at @offset.
void erase_substring(editable_line_t *el, size_t offset, size_t length);
/// Replace the text of length @length at @offset by @replacement.
void replace_substring(editable_line_t *el, size_t offset, size_t length,
const wcstring &replacement);
void replace_substring(editable_line_t *el, size_t offset, size_t length, wcstring replacement);
void push_edit(editable_line_t *el, edit_t &&edit);
/// Insert the character into the command line buffer and print it to the screen using syntax
@ -1440,8 +1439,8 @@ void reader_data_t::erase_substring(editable_line_t *el, size_t offset, size_t l
}
void reader_data_t::replace_substring(editable_line_t *el, size_t offset, size_t length,
const wcstring &replacement) {
push_edit(el, edit_t(offset, length, replacement));
wcstring replacement) {
push_edit(el, edit_t(offset, length, std::move(replacement)));
}
/// Insert the string in the given command line at the given cursor position. The function checks if