github-mirror/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2025-01-20 15:25:31 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

reader: Remove assert in history search

Browse Source 
This isn't a great use of `assert` because it turns a benign "oh I
need to search again" bug into a crash.

Fixes #9628
This commit is contained in:
Fabian Boehm 2023-03-02 16:29:49 +01:00
parent 14f3a5f79a
commit 7c91d009c1
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/reader.cpp
View File

@ -429,8 +429,15 @@ class reader_history_search_t {
const wcstring &needle = search_string();
if (mode_ == line || mode_ == prefix) {
size_t offset = find(text, needle);
assert(offset != wcstring::npos && "Should have found a match in the search result");
add_if_new({std::move(text), offset});
// FIXME: Previous versions asserted out if this wasn't true.
// This could be hit with a needle of "ö" and haystack of "echo Ö"
// I'm not sure why - this points to a bug in ifind (probably wrong locale?)
// However, because the user experience of having it crash is horrible,
// and the worst thing that can otherwise happen here is that a search is unsuccessful,
// we just check it instead.
if (offset != wcstring::npos) {
add_if_new({std::move(text), offset});
}
} else if (mode_ == token) {
auto tok = new_tokenizer(text.c_str(), TOK_ACCEPT_UNFINISHED);