From 8079345207321dc3accc71b41d597996a24e47b8 Mon Sep 17 00:00:00 2001 From: Fabian Homborg Date: Wed, 23 Jan 2019 22:53:53 +0100 Subject: [PATCH] tests/invocation.sh: Use a formatting string with printf Using printf like printf "The message" is unsafe, because if the message contains any formatting characters, they'll be interpreted. In this case it's not all that important because the message contains only filenames of our tests and static strings, but still. --- tests/invocation.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/invocation.sh b/tests/invocation.sh index 5d9664e4c..4f1710c4a 100755 --- a/tests/invocation.sh +++ b/tests/invocation.sh @@ -199,7 +199,7 @@ test_file() { rm -f "${temp_dir}/home/fish/config.fish" fi - printf "Testing file $file ${system_specific:+($system_name specific) }... " + printf '%s' "Testing file $file ${system_specific:+($system_name specific) }... " # The hoops we are jumping through here, with changing directory are # so that we always execute fish as './fish', which means that any