github-mirror/fish-shell
github-mirror/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2025-02-21 00:31:55 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

only swith to shell tty mode if interactive

Browse Source 
My PR #2578 had the unexpected side-effect of altering the tty modes of
commands run via "fish -c command" or "fish scriptname". This change fixes
that; albeit incompletely. The correct solution is to unconditionally set
shell tty modes if stdin is attached to a tty and restore the appropriate
modes whenever an external command is run -- regardless of the path used to
run the external command. The proper fix should be done as part of addressing
issues #2315 and #1041.

Resolves issue #2619
This commit is contained in:
Kurtis Rader 2015-12-25 14:47:30 -08:00 committed by ridiculousfish
parent 076ebf8cee
commit 979b94e274
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/reader.cpp
View File

@ -1053,7 +1053,12 @@ void reader_init()
// earliest possible moment. Doing it here means it will be done within
// approximately 1 ms of the start of the shell rather than 250 ms (or
// more) when reader_interactive_init is eventually called.
tcsetattr(STDIN_FILENO, TCSANOW,&shell_modes);
//
// TODO: Remove this condition when issue #2315 and #1041 are addressed.
if (is_interactive_session)
{
tcsetattr(STDIN_FILENO, TCSANOW,&shell_modes);
}
}