github-mirror/fish-shell
github-mirror/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2025-02-21 00:14:57 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Reenable pgroup eval test in more robust form

Browse Source 
This re-enables the test that eval retains pgroups, from #6806.
The old version was racey and failed a lot. In the new version, we use
temp files to resolve the race.
This commit is contained in:
ridiculousfish 2020-09-13 13:18:01 -07:00
parent 9ba12aad55
commit a698b1f96c
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tests/checks/pipeline-pgroup.fish
View File

@ -40,11 +40,17 @@ and echo "All pgroups agreed"
or echo "Pgroups disagreed. Found $a0 $a1 $a2, and $b0 $b1 $b2"
# CHECK: All pgroups agreed
### DISABLED - this fails a lot on Travis
# Ensure that eval retains pgroups - #6806.
# Our regex will capture the first pgroup and use a positive lookahead on the second.
# $fth print_pgrp | tr \n ' ' 1>&2 | eval '$fth print_pgrp' 1>&2
## CHECKERR: {{(\d+) (?=\1)\d+}}
set -l tmpfile1 (mktemp)
set -l tmpfile2 (mktemp)
$fth print_pgrp > $tmpfile1 | eval '$fth print_pgrp > $tmpfile2'
read -l pgrp1 < $tmpfile1
read -l pgrp2 < $tmpfile2
[ "$pgrp1" -eq "$pgrp2" ]
and echo "eval pgroups agreed"
or echo "eval pgroups disagreed, meaning eval does not retain pgroups: $pgrp1 $pgrp2"
# CHECK: eval pgroups agreed
rm $tmpfile1 $tmpfile2
# Ensure that if a background job launches another background job, that they have different pgroups.
# The pipeline here will arrange for the two pgroups to be printed on the same line, like: