From a755bc5cf6accce3526125eee4506828d72e2e8e Mon Sep 17 00:00:00 2001
From: Rosen Penev <rosenp@gmail.com>
Date: Wed, 27 Nov 2019 17:53:58 -0800
Subject: [PATCH] make_tarball.sh: Run through shellcheck

---
 build_tools/make_tarball.sh | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/build_tools/make_tarball.sh b/build_tools/make_tarball.sh
index d0578e006..ffe12a930 100755
--- a/build_tools/make_tarball.sh
+++ b/build_tools/make_tarball.sh
@@ -32,7 +32,7 @@ fi
 wd="$PWD"
 
 # Get the version from git-describe
-VERSION=`git describe --dirty 2>/dev/null`
+VERSION=$(git describe --dirty 2>/dev/null)
 
 # The name of the prefix, which is the directory that you get when you untar
 prefix="fish-$VERSION"
@@ -48,10 +48,10 @@ rm -f "$path" "$path".gz
 git archive --format=tar --prefix="$prefix"/ HEAD > "$path"
 
 # tarball out the documentation, generate a version file
-PREFIX_TMPDIR=`mktemp -d`
-cd $PREFIX_TMPDIR
-echo $VERSION > version
-cmake $wd
+PREFIX_TMPDIR=$(mktemp -d)
+cd "$PREFIX_TMPDIR"
+echo "$VERSION" > version
+cmake "$wd"
 make doc
 
 TAR_APPEND="$TAR --append --file=$path --mtime=now --owner=0 --group=0 \