mirror of
https://github.com/fish-shell/fish-shell.git
synced 2024-11-26 10:43:47 +08:00
change href attribute to ng-href
Since the url is inside a AngularJS markup {{url}}, it's better to use **ng-href**. From [AngularJS Documentation](https://docs.angularjs.org/api/ng/directive/ngHref): <br> "Using AngularJS markup like {{hash}} in an href attribute will make the link go to the wrong URL if the user clicks it before AngularJS has a chance to replace the {{hash}} markup with its value. Until AngularJS replaces the markup the link will be broken and will most likely return a 404 error. The ngHref directive solves this problem."
This commit is contained in:
parent
2810ba0014
commit
af48fa5d91
|
@ -127,7 +127,7 @@ fish cannot change the background color of your terminal. Refer to your terminal
|
|||
<div class="color_scheme_choice_label">
|
||||
<!-- This click/clickBubble nonsense is so that we can have a separate URL inside a parent with an onClick handler -->
|
||||
{{colorScheme.name}}
|
||||
<a data-ng-show="colorScheme.url" style="text-decoration: none; color: inherit;" href="{{colorScheme.url}}">➚</a>
|
||||
<a data-ng-show="colorScheme.url" style="text-decoration: none; color: inherit;" ng-href="{{colorScheme.url}}">➚</a>
|
||||
</div>
|
||||
<div class="colorpicker_text_sample_tight" data-ng-style="{'background-color': colorScheme.preferred_background}">
|
||||
<span data-ng-style="{'color': colorScheme.command}">/bright/vixens</span>
|
||||
|
|
Loading…
Reference in New Issue
Block a user