github-mirror/fish-shell
github-mirror/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2025-02-23 08:01:11 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix env_universal_common.cpp filesize comparisons.

Browse Source 
* if (result == ULLONG_MAX) is always false, likely a typo as
  result is unsigned long, and the comment says ULONG_MAX.

* use off_t instead of size_t for file size where it can mismatch
  st_size's type in stat.h
This commit is contained in:
Aaron Gyes 2016-06-12 03:39:36 -07:00
parent 3a7719015d
commit b72ed1fa8c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/env_universal_common.cpp
View File

@ -1023,7 +1023,7 @@ class universal_notifier_shmem_poller_t : public universal_notifier_t {
}
// Get the size.
size_t size = 0;
off_t size = 0;
if (!errored) {
struct stat buf = {};
if (fstat(fd, &buf) < 0) {
@ -1352,7 +1352,7 @@ class universal_notifier_named_pipe_t : public universal_notifier_t {
// Now return the smaller of the two values. If we get ULONG_MAX, it means there's no more
// need to poll; in that case return 0.
unsigned long result = mini(readback_delay, polling_delay);
if (result == ULLONG_MAX) {
if (result == ULONG_MAX) {
result = 0;
}
return result;