From cdc08dbb716d2a859e671988e44dce8ddf033d02 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20H=C3=B8rl=C3=BCck=20Berg?= <36937807+henrikhorluck@users.noreply.github.com> Date: Thu, 27 Jul 2023 08:09:12 +0200 Subject: [PATCH] Add back well-backed comment - The dermination is from commit 7988cff6bd6b4863927e01c9aaad1559745a5371 - See PR https://github.com/fish-shell/fish-shell/pull/9139 --- fish-rust/src/builtins/string.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fish-rust/src/builtins/string.rs b/fish-rust/src/builtins/string.rs index 0583d0f7a..1ba8f6c9c 100644 --- a/fish-rust/src/builtins/string.rs +++ b/fish-rust/src/builtins/string.rs @@ -327,6 +327,9 @@ impl Drop for Arguments<'_, '_> { } impl<'args, 'iter> Arguments<'args, 'iter> { + /// Empirically determined. + /// This is probably down to some pipe buffer or some such, + /// but too small means we need to call `read(2)` and str2wcstring a lot. const STRING_CHUNK_SIZE: usize = 1024; fn new(