github-mirror/fish-shell
github-mirror/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2025-03-07 02:37:43 +08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

history_file_contents_t::create: remove constant comparison

Browse Source 
static_cast<unsigned long>(off_t len) is always < SIZE_MAX
This commit is contained in:
Aaron Gyes 2022-04-01 09:23:44 -07:00
parent 338d587f2a
commit d7b4193978
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/history_file.cpp
View File

@ -157,7 +157,7 @@ bool history_file_contents_t::infer_file_type() {
std::unique_ptr<history_file_contents_t> history_file_contents_t::create(int fd) { std::unique_ptr<history_file_contents_t> history_file_contents_t::create(int fd) {
// Check that the file is seekable, and its size. // Check that the file is seekable, and its size.
off_t len = lseek(fd, 0, SEEK_END); off_t len = lseek(fd, 0, SEEK_END);
if (len <= 0 || static_cast<unsigned long>(len) >= SIZE_MAX) return nullptr; if (len <= 0) return nullptr;
bool mmap_file_directly = should_mmap(); bool mmap_file_directly = should_mmap();
std::unique_ptr<mmap_region_t> region = std::unique_ptr<mmap_region_t> region =