github-mirror/fish-shell
github-mirror/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2025-03-22 02:35:14 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Replace some #warnings with a comment explaining why the code is OK

Browse Source
This commit is contained in:
ridiculousfish 2013-08-19 18:17:01 -07:00
parent 4899086b3c
commit ee113a5632
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
exec.cpp
View File

@ -909,7 +909,7 @@ void exec_job(parser_t &parser, job_t *j)
}
else
{
#warning is this bad because we need to be able to read this from select_try?
/* This looks sketchy, because we're adding this io buffer locally - they aren't in the process or job redirection list. Therefore select_try won't be able to read them. However we call block_output_io_buffer->read() below, which reads until EOF. So there's no need to select on this. */
process_net_io_chain.push_back(block_output_io_buffer);
}
}
@ -929,7 +929,6 @@ void exec_job(parser_t &parser, job_t *j)
{
if (p->next)
{
#warning is this bad because we need to be able to read this from select_try?
block_output_io_buffer.reset(io_buffer_t::create(0));
if (block_output_io_buffer.get() == NULL)
{
@ -938,6 +937,7 @@ void exec_job(parser_t &parser, job_t *j)
}
else
{
/* See the comment above about it's OK to add an IO redirection to this local buffer, even though it won't be handled in select_try */
process_net_io_chain.push_back(block_output_io_buffer);
}
}