From f58f2e14a37a3f432d8c39267dc6775ba1514298 Mon Sep 17 00:00:00 2001 From: Fabian Homborg Date: Sat, 7 Nov 2020 07:42:40 +0100 Subject: [PATCH] tests/bind: Increase escape delay We just had the following output on Github Actions: INPUT +0.94 ms (Line 34): echo ghi jkl INPUT +0.72 ms (Line 35): \x1b INPUT +63.12 ms (Line 37): t\r The default escape delay is 30ms, that had 60ms between an escape and a tab, so it missed it. So: We have to increase the delay for CI's benefit. Let's try with 80ms, because otherwise we'd have to bump up other timeouts and the bind tests take long enough as it is. --- tests/pexpects/bind.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/pexpects/bind.py b/tests/pexpects/bind.py index 70fd3c49b..5771b9f63 100644 --- a/tests/pexpects/bind.py +++ b/tests/pexpects/bind.py @@ -20,6 +20,11 @@ expect_prompt(increment=False) # Fish should start in default-mode (i.e., emacs) bindings. The default escape # timeout is 30ms. +# +# Because common CI systems are awful, we have to increase this: + +sendline("set -g fish_escape_delay_ms 80") +expect_prompt("") # Verify the emacs transpose word (\et) behavior using various delays, # including none, after the escape character. @@ -42,7 +47,7 @@ expect_prompt("\r\njkl ghi\r\n") # occur and the "t" should become part of the text that is echoed. send("echo mno pqr") send("\033") -sleep(0.200) +sleep(0.100) send("t\r") # emacs transpose words, default timeout: long delay expect_prompt("\r\nmno pqrt\r\n")