fish-shell

github-mirror/fish-shell

Fork 0

mirror of https://github.com/fish-shell/fish-shell.git synced 2024-11-24 00:50:37 +08:00

Commit Graph

Author	SHA1	Message	Date
Kurtis Rader	483e9fdea2	check if locking takes too long If acquiring a lock on the history or uvar file takes more than 250 ms disable locking of the file. On systems with broken remote file system locking it can cause tens of seconds delay after running each command which can make the shell borderline unusable. This also changes history file locking to use flock() rather than fcntl() to be consistent with uvar file locking. It also implements the 250 ms time limit before giving up on locking. Fixes #685	2016-12-16 21:20:08 -08:00
Kurtis Rader	521546a986	fix some lint warnings This fixes some of the IWYU and cppcheck lint warnings. And only on macOS (formerly OS X). Fixing these types of warnings on a broader set of platforms should be done but this is a baby step to making `make lint-all` have few, if any, warnings. This reduces the number of lines in the `make lint-all` output on macOS by over 500 lines.	2016-11-15 21:15:22 -08:00
Kurtis Rader	8645aa94c8	improve linting tool I found that after fixing the args to `cppcheck` it started reporting lots of varFuncNullUB warnings. Suppress them as they should be safe to ignore. Also, improve the readability of the script.	2016-11-14 19:20:12 -08:00

Author

SHA1

Message

Date

Kurtis Rader

483e9fdea2

check if locking takes too long

If acquiring a lock on the history or uvar file takes more than 250 ms
disable locking of the file. On systems with broken remote file system
locking it can cause tens of seconds delay after running each command
which can make the shell borderline unusable.

This also changes history file locking to use flock() rather than
fcntl() to be consistent with uvar file locking. It also implements the
250 ms time limit before giving up on locking.

Fixes #685

2016-12-16 21:20:08 -08:00

Kurtis Rader

521546a986

fix some lint warnings

This fixes some of the IWYU and cppcheck lint warnings. And only on
macOS (formerly OS X). Fixing these types of warnings on a broader set
of platforms should be done but this is a baby step to making `make
lint-all` have few, if any, warnings. This reduces the number of lines
in the `make lint-all` output on macOS by over 500 lines.

2016-11-15 21:15:22 -08:00

Kurtis Rader

8645aa94c8

improve linting tool

I found that after fixing the args to `cppcheck` it started reporting
lots of varFuncNullUB warnings. Suppress them as they should be safe to
ignore. Also, improve the readability of the script.

2016-11-14 19:20:12 -08:00

3 Commits