mirror of
https://github.com/fish-shell/fish-shell.git
synced 2024-11-24 07:24:51 +08:00
9d2b53450a
The existing implementation grows the $dirprev array without bounds. Besides causing what would appear to be a memory leak it also makes the nextd and prevd commands more expensive than they need to be. It also makes it harder to create a useful "menu" cd command. In addition to implementing a reasonable limit on the size of the $dirprev array I've reformatted the code using fish_indent. Update the documentation to include mentions of the $dirprev and $dirnext variables as well as the limit on how much directory history is kept. Fixes 2836
42 lines
910 B
Fish
42 lines
910 B
Fish
#
|
|
# Wrap the builtin cd command to maintain directory history.
|
|
#
|
|
function cd --description "Change directory"
|
|
set -l MAX_DIR_HIST 25
|
|
|
|
if test (count $argv) -gt 1
|
|
printf "%s\n" (_ "Too many args for cd command")
|
|
return 1
|
|
end
|
|
|
|
# Skip history in subshells.
|
|
if status --is-command-substitution
|
|
builtin cd $argv
|
|
return $status
|
|
end
|
|
|
|
# Avoid set completions
|
|
set -l previous $PWD
|
|
|
|
if test "$argv" = "-"
|
|
if test "$__fish_cd_direction" = "next"
|
|
nextd
|
|
else
|
|
prevd
|
|
end
|
|
return $status
|
|
end
|
|
|
|
builtin cd $argv
|
|
set -l cd_status $status
|
|
|
|
if test $cd_status -eq 0 -a "$PWD" != "$previous"
|
|
set -q dirprev[$MAX_DIR_HIST]; and set -e dirprev[1]
|
|
set -g dirprev $dirprev $previous
|
|
set -e dirnext
|
|
set -g __fish_cd_direction prev
|
|
end
|
|
|
|
return $cd_status
|
|
end
|