github-mirror/framework
github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2025-02-27 19:49:39 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

if a tag does not exist, we dont want the query to crash (#61)

Browse Source 
* if a tag does not exist, we dont want the query to crash

* incorrect solution
Revert "if a tag does not exist, we dont want the query to crash"

This reverts commit 6680e5a6e838ff9f53d338581d655671597b7bc5.

* repaired getIdForSlug function to return int or null

* changed where, removed isempty not needed
This commit is contained in:
Thomas Lang 2019-06-03 12:00:23 +02:00 committed by Franz Liedke
parent 554e906c2b
commit 0536d10739
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/tags/src/TagRepository.php
View File

@ -63,11 +63,11 @@ class TagRepository
* @param User|null $user
* @return int
*/
public function getIdForSlug($slug, User $user = null)
public function getIdForSlug($slug, User $user = null) : ?int
{
$query = Tag::where('slug', 'like', $slug);
$query = Tag::where('slug', $slug);
return $this->scopeVisibleTo($query, $user)->pluck('id');
return $this->scopeVisibleTo($query, $user)->value('id');
}
/**