github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2025-02-15 01:22:52 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Rename onshow and onhide

Browse Source 
animateShow and animateHide are more descriptive
This commit is contained in:
Alexander Skvortsov 2020-09-29 18:37:26 -04:00
parent e798cb104b
commit 12bfff9b5d
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
framework/core/js/src/common/components/Modal.js
View File

@ -24,7 +24,7 @@ export default class Modal extends Component {
oncreate(vnode) { oncreate(vnode) {
super.oncreate(vnode); super.oncreate(vnode);
this.attrs.onshow(() => this.onready()); this.attrs.animateShow(() => this.onready());
} }
onbeforeremove() { onbeforeremove() {
@ -32,7 +32,7 @@ export default class Modal extends Component {
// we've just opened up a new one, and accordingly, // we've just opened up a new one, and accordingly,
// we don't need to show a hide animation. // we don't need to show a hide animation.
if (!this.attrs.state.modal) { if (!this.attrs.state.modal) {
this.attrs.onhide(); this.attrs.animateHide();
} }
} }

4
framework/core/js/src/common/components/ModalManager.js
View File

@ -14,8 +14,8 @@ export default class ModalManager extends Component {
{modal {modal
? modal.componentClass.component({ ? modal.componentClass.component({
...modal.attrs, ...modal.attrs,
onshow: this.animateShow.bind(this), animateShow: this.animateShow.bind(this),
onhide: this.animateHide.bind(this), animateHide: this.animateHide.bind(this),
state: this.attrs.state, state: this.attrs.state,
}) })
: ''} : ''}