github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2024-11-22 09:48:15 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: first posts having NULL as value for number column (#3414)

Browse Source 
* fix: first posts having `NULL` as value for `number` column
* chore: add note about raw db function `IFNULL`
This commit is contained in:
Sami Mazouz 2022-05-08 23:21:11 +01:00 committed by GitHub
parent 2e89ba3c94
commit 1954d0383e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.gitignore vendored
View File

@ -1 +1,3 @@
node_modules node_modules
vendor
composer.lock

7
framework/core/src/Post/Post.php
View File

@ -96,10 +96,11 @@ class Post extends AbstractModel
/** @var ConnectionInterface $db */ /** @var ConnectionInterface $db */
$db = static::getConnectionResolver(); $db = static::getConnectionResolver();
$post->number = new Expression('('.$db $post->number = new Expression('('.
->table('posts', 'pn') $db->table('posts', 'pn')
->whereRaw($db->getTablePrefix().'pn.discussion_id = '.intval($post->discussion_id)) ->whereRaw($db->getTablePrefix().'pn.discussion_id = '.intval($post->discussion_id))
->select($db->raw('max('.$db->getTablePrefix().'pn.number) + 1')) // IFNULL only works on MySQL/MariaDB
->selectRaw('IFNULL(MAX('.$db->getTablePrefix().'pn.number), 0) + 1')
->toSql() ->toSql()
.')'); .')');
}); });