From 1c152a72654425d1789e9ad901b32d9a5eee7a3b Mon Sep 17 00:00:00 2001
From: Franz Liedke <franz@develophp.org>
Date: Mon, 16 Jul 2018 00:33:32 +0200
Subject: [PATCH] Installer: Get rid of an instance variable
Leftover from PR #1405.
---
framework/core/src/Install/Console/InstallCommand.php | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/framework/core/src/Install/Console/InstallCommand.php b/framework/core/src/Install/Console/InstallCommand.php
index 58080032a..43834b9d5 100644
--- a/framework/core/src/Install/Console/InstallCommand.php
+++ b/framework/core/src/Install/Console/InstallCommand.php
@@ -138,7 +138,6 @@ class InstallCommand extends AbstractCommand
protected function install()
{
try {
- $this->debug = $this->dataSource->isDebugMode();
$this->dbConfig = $this->dataSource->getDatabaseConfiguration();
$validation = $this->getValidator()->make(
@@ -177,7 +176,7 @@ class InstallCommand extends AbstractCommand
throw new Exception('Username can only contain letters, numbers, underscores, and dashes.');
}
- $this->storeConfiguration();
+ $this->storeConfiguration($this->dataSource->isDebugMode());
$resolver = $this->application->make(ConnectionResolverInterface::class);
AbstractModel::setConnectionResolver($resolver);
@@ -210,12 +209,12 @@ class InstallCommand extends AbstractCommand
}
}
- protected function storeConfiguration()
+ protected function storeConfiguration(bool $debugMode)
{
$dbConfig = $this->dbConfig;
$config = [
- 'debug' => $this->debug,
+ 'debug' => $debugMode,
'database' => [
'driver' => $dbConfig['driver'],
'host' => $dbConfig['host'],