github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2025-02-16 02:23:10 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(webpack): chunk module path checking fails with dotted directories (#4179)

Browse Source 
Resolves issues when the path contains unexpected periods
This commit is contained in:
Davide Iadeluca 2025-02-08 17:50:12 +01:00 committed by GitHub
parent 863d6526df
commit 333bbb11e2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
js-packages/webpack-config/src/RegisterAsyncChunksPlugin.cjs
View File

@ -81,10 +81,13 @@ class RegisterAsyncChunksPlugin {
const chunkModules = (c) => Array.from(compilation.chunkGraph.getChunkModulesIterable(c));
const relevantChunk = chunks.find((chunk) =>
chunkModules(chunk)?.find(
(module) =>
module.resource?.split('.')[0] === importPathResolved || module.rootModule?.resource?.split('.')[0] === importPathResolved
)
chunkModules(chunk)?.find((module) => {
const resourceWithoutExt = module.resource ? module.resource.replace(path.extname(module.resource), '') : '';
const rootResourceWithoutExt = module.rootModule?.resource
? module.rootModule.resource.replace(path.extname(module.rootModule.resource), '')
: '';
return resourceWithoutExt === importPathResolved || rootResourceWithoutExt === importPathResolved;
})
);
if (!relevantChunk) {
@ -94,7 +97,11 @@ class RegisterAsyncChunksPlugin {
const relevantChunkModules = chunkModules(relevantChunk);
const mainModule = relevantChunkModules.filter((m) => {
return m.resource?.split('.')[0] === importPathResolved || m.rootModule?.resource?.split('.')[0] === importPathResolved;
const resourceWithoutExt = m.resource ? m.resource.replace(path.extname(m.resource), '') : '';
const rootResourceWithoutExt = m.rootModule?.resource
? m.rootModule.resource.replace(path.extname(m.rootModule.resource), '')
: '';
return resourceWithoutExt === importPathResolved || rootResourceWithoutExt === importPathResolved;
})[0];
const otherRelevantChunkModules = relevantChunkModules.filter((m) => m !== mainModule);