github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2025-02-11 03:49:44 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix discussion unreadCount could be higher than commentCount (#2195)

Browse Source 
* Fix discussion unreadCount being higher than commentCount if posts have been deleted
This commit is contained in:
w-4 2020-06-20 21:18:26 +07:00 committed by GitHub
parent f14da4b159
commit 395ee845ae
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
framework/core/js/src/common/models/Discussion.js
View File

@ -68,7 +68,10 @@ Object.assign(Discussion.prototype, {
const user = app.session.user; const user = app.session.user;
if (user && user.markedAllAsReadAt() < this.lastPostedAt()) { if (user && user.markedAllAsReadAt() < this.lastPostedAt()) {
return Math.max(0, this.lastPostNumber() - (this.lastReadPostNumber() || 0)); const unreadCount = Math.max(0, this.lastPostNumber() - (this.lastReadPostNumber() || 0));
// If posts have been deleted, it's possible that the unread count could exceed the
// actual post count. As such, we take the min of the two to ensure this isn't an issue.
return Math.min(unreadCount, this.commentCount());
} }
return 0; return 0;