github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2024-11-24 06:59:42 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove unneeded check in item-list template

Browse Source 
If the `isHiddenInList` property is changed to true (e.g. via a
computed property), then that view is removed, and its computed
properties are unhooks — so the `isHiddenInList` property won’t update
and the view can’t be shown again. Items should be hidden via CSS
instead.
This commit is contained in:
Toby Zerner 2015-03-28 11:45:33 +10:30
parent 5ca3b5e0f6
commit 3c3f8242e2
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ember/app/templates/components/ui/item-list.hbs
View File

@ -1,9 +1,7 @@
{{#each item in listItems}}
{{#unless item.isHiddenInList}}
{{#if item.isListItem}}
{{view item}}
{{else}}
<li class="{{item.listItemClass}}">{{view item}}</li>
{{/if}}
{{/unless}}
{{#if item.isListItem}}
{{view item}}
{{else}}
<li class="{{item.listItemClass}}">{{view item}}</li>
{{/if}}
{{/each}}