github-mirror/framework
github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2025-02-21 10:42:46 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(tags): TagDiscussionModal don't go to null tag (#3404)

Browse Source 
If the tag we are trying to select/highlight is undefined, we should not run the scroll animation.
This commit is contained in:
Alexander Skvortsov 2022-04-21 18:03:41 -04:00 committed by GitHub
parent 42602a099f
commit 4cb15501a2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/tags/js/src/forum/components/TagDiscussionModal.tsx
View File

@ -322,7 +322,7 @@ export default class TagDiscussionModal extends Modal<TagDiscussionModalAttrs> {
m.redraw();
if (scrollToItem) {
if (scrollToItem && this.selectedTag) {
const dropdownScroll = $dropdown.scrollTop()!;
const dropdownTop = $dropdown.offset()!.top;
const dropdownBottom = dropdownTop + $dropdown.outerHeight()!;