From cfb4406b55ed3c8ee52f83e8d5661417db280993 Mon Sep 17 00:00:00 2001 From: dcsjapan Date: Wed, 23 Sep 2015 14:58:33 +0900 Subject: [PATCH] Primary key renaming MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Improved consistency for existing core translation key names. See flarum/core#265 - Completely overhauled core en.yml - Replaced existing key names in all core JS files to match - Extracted a hardcoded string in IndexPage.js - Combined two app.trans calls in DiscussionControls.js - Removed hardcoded spaces from LogInModal.js and SignUpModal.js - Added two new keys from DiscussionControls.js (soft delete) - Created two new “reused keys” to YML to accommodate same --- .../js/forum/src/components/AvatarEditor.js | 4 +- .../forum/src/components/ChangeEmailModal.js | 9 +- .../src/components/ChangePasswordModal.js | 6 +- .../core/js/forum/src/components/Composer.js | 8 +- .../src/components/DiscussionComposer.js | 8 +- .../js/forum/src/components/DiscussionList.js | 2 +- .../src/components/DiscussionListItem.js | 4 +- .../DiscussionRenamedNotification.js | 2 +- .../src/components/DiscussionRenamedPost.js | 2 +- .../src/components/DiscussionsSearchSource.js | 4 +- .../forum/src/components/EditPostComposer.js | 6 +- .../js/forum/src/components/EditUserModal.js | 8 +- .../src/components/ForgotPasswordModal.js | 13 +- .../forum/src/components/HeaderSecondary.js | 4 +- .../core/js/forum/src/components/IndexPage.js | 12 +- .../js/forum/src/components/LogInModal.js | 19 +- .../forum/src/components/NotificationGrid.js | 6 +- .../forum/src/components/NotificationList.js | 6 +- .../src/components/NotificationsDropdown.js | 2 +- .../js/forum/src/components/PostEdited.js | 2 +- .../core/js/forum/src/components/PostMeta.js | 2 +- .../js/forum/src/components/PostStream.js | 2 +- .../src/components/PostStreamScrubber.js | 8 +- .../js/forum/src/components/PostsUserPage.js | 2 +- .../js/forum/src/components/ReplyComposer.js | 10 +- .../forum/src/components/ReplyPlaceholder.js | 2 +- .../core/js/forum/src/components/Search.js | 2 +- .../forum/src/components/SessionDropdown.js | 8 +- .../js/forum/src/components/SettingsPage.js | 14 +- .../js/forum/src/components/SignUpModal.js | 22 +- .../js/forum/src/components/TerminalPost.js | 3 +- .../core/js/forum/src/components/UserBio.js | 4 +- .../core/js/forum/src/components/UserCard.js | 6 +- .../core/js/forum/src/components/UserPage.js | 6 +- .../forum/src/components/UsersSearchSource.js | 2 +- .../js/forum/src/utils/DiscussionControls.js | 19 +- .../core/js/forum/src/utils/PostControls.js | 8 +- .../core/js/forum/src/utils/UserControls.js | 4 +- framework/core/js/lib/helpers/username.js | 3 +- framework/core/locale/en.yml | 300 +++++++++++++----- 40 files changed, 344 insertions(+), 210 deletions(-) diff --git a/framework/core/js/forum/src/components/AvatarEditor.js b/framework/core/js/forum/src/components/AvatarEditor.js index 9569d888d..5d8bce057 100644 --- a/framework/core/js/forum/src/components/AvatarEditor.js +++ b/framework/core/js/forum/src/components/AvatarEditor.js @@ -62,7 +62,7 @@ export default class AvatarEditor extends Component { items.add('upload', Button.component({ icon: 'upload', - children: app.trans('core.upload'), + children: app.trans('core.user_avatar_upload_button'), onclick: this.upload.bind(this) }) ); @@ -70,7 +70,7 @@ export default class AvatarEditor extends Component { items.add('remove', Button.component({ icon: 'times', - children: app.trans('core.remove'), + children: app.trans('core.user_avatar_remove_button'), onclick: this.remove.bind(this) }) ); diff --git a/framework/core/js/forum/src/components/ChangeEmailModal.js b/framework/core/js/forum/src/components/ChangeEmailModal.js index 635154928..8e5e22b67 100644 --- a/framework/core/js/forum/src/components/ChangeEmailModal.js +++ b/framework/core/js/forum/src/components/ChangeEmailModal.js @@ -29,7 +29,7 @@ export default class ChangeEmailModal extends Modal { } title() { - return app.trans('core.change_email'); + return app.trans('core.change_email_title'); } content() { @@ -39,10 +39,11 @@ export default class ChangeEmailModal extends Modal { return (
-

{app.trans('core.confirmation_email_sent', {email: {this.email()}})}

+

{app.trans('core.change_email_confirmation_message', {email: {this.email()}})}

+ // Core Key Reorganization: This needs to be changed to a dismiss button! - {app.trans('core.go_to', {location: emailProviderName})} + {app.trans('core.change_email_dismiss_button', {location: emailProviderName})}
@@ -65,7 +66,7 @@ export default class ChangeEmailModal extends Modal { className: 'Button Button--primary Button--block', type: 'submit', loading: this.loading, - children: app.trans('core.save_changes') + children: app.trans('core.change_email_submit_button') })}
diff --git a/framework/core/js/forum/src/components/ChangePasswordModal.js b/framework/core/js/forum/src/components/ChangePasswordModal.js index 79d427da9..a9f7de327 100644 --- a/framework/core/js/forum/src/components/ChangePasswordModal.js +++ b/framework/core/js/forum/src/components/ChangePasswordModal.js @@ -11,20 +11,20 @@ export default class ChangePasswordModal extends Modal { } title() { - return app.trans('core.change_password'); + return app.trans('core.change_password_title'); } content() { return (
-

{app.trans('core.change_password_help')}

+

{app.trans('core.change_password_text')}

{Button.component({ className: 'Button Button--primary Button--block', type: 'submit', loading: this.loading, - children: app.trans('core.send_password_reset_email') + children: app.trans('core.change_password_send_button') })}
diff --git a/framework/core/js/forum/src/components/Composer.js b/framework/core/js/forum/src/components/Composer.js index 41e068359..05d50234e 100644 --- a/framework/core/js/forum/src/components/Composer.js +++ b/framework/core/js/forum/src/components/Composer.js @@ -460,28 +460,28 @@ class Composer extends Component { if (this.position === Composer.PositionEnum.FULLSCREEN) { items.add('exitFullScreen', ComposerButton.component({ icon: 'compress', - title: app.trans('core.exit_full_screen'), + title: app.trans('core.composer_exit_full_screen_tooltip'), onclick: this.exitFullScreen.bind(this) })); } else { if (this.position !== Composer.PositionEnum.MINIMIZED) { items.add('minimize', ComposerButton.component({ icon: 'minus minimize', - title: app.trans('core.minimize'), + title: app.trans('core.composer_minimize_tooltip'), onclick: this.minimize.bind(this), itemClassName: 'App-backControl' })); items.add('fullScreen', ComposerButton.component({ icon: 'expand', - title: app.trans('core.full_screen'), + title: app.trans('core.composer_full_screen_tooltip'), onclick: this.fullScreen.bind(this) })); } items.add('close', ComposerButton.component({ icon: 'times', - title: app.trans('core.close'), + title: app.trans('core.composer_close_tooltip'), onclick: this.close.bind(this) })); } diff --git a/framework/core/js/forum/src/components/DiscussionComposer.js b/framework/core/js/forum/src/components/DiscussionComposer.js index dbf513a9e..e0dd08808 100644 --- a/framework/core/js/forum/src/components/DiscussionComposer.js +++ b/framework/core/js/forum/src/components/DiscussionComposer.js @@ -26,10 +26,10 @@ export default class DiscussionComposer extends ComposerBody { static initProps(props) { super.initProps(props); - props.placeholder = props.placeholder || app.trans('core.write_a_post'); - props.submitLabel = props.submitLabel || app.trans('core.post_discussion'); - props.confirmExit = props.confirmExit || app.trans('core.confirm_discard_discussion'); - props.titlePlaceholder = props.titlePlaceholder || app.trans('core.discussion_title'); + props.placeholder = props.placeholder || app.trans('core.composer_discussion_body_placeholder'); + props.submitLabel = props.submitLabel || app.trans('core.composer_discussion_submit_button'); + props.confirmExit = props.confirmExit || app.trans('core.composer_discussion_discard_confirmation'); + props.titlePlaceholder = props.titlePlaceholder || app.trans('core.composer_discussion_title_placeholder'); } headerItems() { diff --git a/framework/core/js/forum/src/components/DiscussionList.js b/framework/core/js/forum/src/components/DiscussionList.js index 028ad4b06..d0aabbb53 100644 --- a/framework/core/js/forum/src/components/DiscussionList.js +++ b/framework/core/js/forum/src/components/DiscussionList.js @@ -48,7 +48,7 @@ export default class DiscussionList extends Component { loading = LoadingIndicator.component(); } else if (this.moreResults) { loading = Button.component({ - children: app.trans('core.load_more'), + children: app.trans('core.discussion_list_load_more_button'), className: 'Button', onclick: this.loadMore.bind(this) }); diff --git a/framework/core/js/forum/src/components/DiscussionListItem.js b/framework/core/js/forum/src/components/DiscussionListItem.js index 937cb777b..0bc257989 100644 --- a/framework/core/js/forum/src/components/DiscussionListItem.js +++ b/framework/core/js/forum/src/components/DiscussionListItem.js @@ -87,7 +87,7 @@ export default class DiscussionListItem extends Component {
+ title={showUnread ? app.trans('core.discussion_list_mark_as_read_tooltip') : ''}> {abbreviateNumber(discussion[showUnread ? 'unreadCount' : 'repliesCount']())} diff --git a/framework/core/js/forum/src/components/DiscussionRenamedNotification.js b/framework/core/js/forum/src/components/DiscussionRenamedNotification.js index e29352f58..b0b6224ca 100644 --- a/framework/core/js/forum/src/components/DiscussionRenamedNotification.js +++ b/framework/core/js/forum/src/components/DiscussionRenamedNotification.js @@ -20,6 +20,6 @@ export default class DiscussionRenamedNotification extends Notification { } content() { - return app.trans('core.discussion_renamed_notification', {user: this.props.notification.sender()}); + return app.trans('core.notifications_discussion_renamed_text', {user: this.props.notification.sender()}); } } diff --git a/framework/core/js/forum/src/components/DiscussionRenamedPost.js b/framework/core/js/forum/src/components/DiscussionRenamedPost.js index 3e1220cc4..ce5143a02 100644 --- a/framework/core/js/forum/src/components/DiscussionRenamedPost.js +++ b/framework/core/js/forum/src/components/DiscussionRenamedPost.js @@ -14,7 +14,7 @@ export default class DiscussionRenamedPost extends EventPost { } descriptionKey() { - return 'core.discussion_renamed_post'; + return 'core.post_stream_discussion_renamed_text'; } descriptionData() { diff --git a/framework/core/js/forum/src/components/DiscussionsSearchSource.js b/framework/core/js/forum/src/components/DiscussionsSearchSource.js index c50e50339..daaf6c394 100644 --- a/framework/core/js/forum/src/components/DiscussionsSearchSource.js +++ b/framework/core/js/forum/src/components/DiscussionsSearchSource.js @@ -28,11 +28,11 @@ export default class DiscussionsSearchSource { const results = this.results[query] || []; return [ -
  • {app.trans('core.discussions')}
  • , +
  • {app.trans('core.search_discussions_heading')}
  • ,
  • {LinkButton.component({ icon: 'search', - children: app.trans('core.search_all_discussions', {query}), + children: app.trans('core.search_all_discussions_button', {query}), href: app.route('index', {q: query}) })}
  • , diff --git a/framework/core/js/forum/src/components/EditPostComposer.js b/framework/core/js/forum/src/components/EditPostComposer.js index 4ea70a361..fe84d5bee 100644 --- a/framework/core/js/forum/src/components/EditPostComposer.js +++ b/framework/core/js/forum/src/components/EditPostComposer.js @@ -23,8 +23,8 @@ export default class EditPostComposer extends ComposerBody { static initProps(props) { super.initProps(props); - props.submitLabel = props.submitLabel || app.trans('core.save_changes'); - props.confirmExit = props.confirmExit || app.trans('core.confirm_discard_edit'); + props.submitLabel = props.submitLabel || app.trans('core.composer_edit_submit_button'); + props.confirmExit = props.confirmExit || app.trans('core.composer_edit_discard_confirmation'); props.originalContent = props.originalContent || props.post.content(); props.user = props.user || props.post.user(); @@ -39,7 +39,7 @@ export default class EditPostComposer extends ComposerBody {

    {icon('pencil')}{' '} - {app.trans('core.editing_post', {number: post.number(), discussion: post.discussion().title()})} + {app.trans('core.composer_edit_post_link', {number: post.number(), discussion: post.discussion().title()})}

    )); diff --git a/framework/core/js/forum/src/components/EditUserModal.js b/framework/core/js/forum/src/components/EditUserModal.js index 6f7cbb96b..be808d497 100644 --- a/framework/core/js/forum/src/components/EditUserModal.js +++ b/framework/core/js/forum/src/components/EditUserModal.js @@ -37,7 +37,7 @@ export default class EditUserModal extends Modal {
    -
    @@ -45,7 +45,7 @@ export default class EditUserModal extends Modal {
    -
    @@ -64,7 +64,7 @@ export default class EditUserModal extends Modal { Set new password {this.setPassword() ? ( - ) : ''} @@ -93,7 +93,7 @@ export default class EditUserModal extends Modal { className: 'Button Button--primary', type: 'submit', loading: this.loading, - children: app.trans('core.save_changes') + children: app.trans('core.edit_user_submit_button') })}
    diff --git a/framework/core/js/forum/src/components/ForgotPasswordModal.js b/framework/core/js/forum/src/components/ForgotPasswordModal.js index 4436dbff4..ef1e93fef 100644 --- a/framework/core/js/forum/src/components/ForgotPasswordModal.js +++ b/framework/core/js/forum/src/components/ForgotPasswordModal.js @@ -34,7 +34,7 @@ export default class ForgotPasswordModal extends Modal { } title() { - return app.trans('core.forgot_password'); + return app.trans('core.forgot_password_title'); } content() { @@ -44,10 +44,11 @@ export default class ForgotPasswordModal extends Modal { return (
    -

    {app.trans('core.password_reset_email_sent')}

    +

    {app.trans('core.forgot_password_email_sent_message')}

    @@ -58,9 +59,9 @@ export default class ForgotPasswordModal extends Modal { return (
    -

    {app.trans('core.forgot_password_help')}

    +

    {app.trans('core.forgot_password_text')}

    - @@ -70,7 +71,7 @@ export default class ForgotPasswordModal extends Modal { className: 'Button Button--primary Button--block', type: 'submit', loading: this.loading, - children: app.trans('core.recover_password') + children: app.trans('core.forgot_password_submit_button') })}
    diff --git a/framework/core/js/forum/src/components/HeaderSecondary.js b/framework/core/js/forum/src/components/HeaderSecondary.js index 74500468f..338fcc701 100644 --- a/framework/core/js/forum/src/components/HeaderSecondary.js +++ b/framework/core/js/forum/src/components/HeaderSecondary.js @@ -64,7 +64,7 @@ export default class HeaderSecondary extends Component { if (app.forum.attribute('allowSignUp')) { items.add('signUp', Button.component({ - children: app.trans('core.sign_up'), + children: app.trans('core.header_sign_up_link'), className: 'Button Button--link', onclick: () => app.modal.show(new SignUpModal()) }), 10 @@ -73,7 +73,7 @@ export default class HeaderSecondary extends Component { items.add('logIn', Button.component({ - children: app.trans('core.log_in'), + children: app.trans('core.header_log_in_link'), className: 'Button Button--link', onclick: () => app.modal.show(new LogInModal()) }), 0 diff --git a/framework/core/js/forum/src/components/IndexPage.js b/framework/core/js/forum/src/components/IndexPage.js index 5ba46e216..ad03dff99 100644 --- a/framework/core/js/forum/src/components/IndexPage.js +++ b/framework/core/js/forum/src/components/IndexPage.js @@ -147,7 +147,8 @@ export default class IndexPage extends Page { items.add('newDiscussion', Button.component({ - children: canStartDiscussion ? app.trans('core.start_a_discussion') : 'Can\'t Start Discussion', + // Core Key Reorganization: Extracted the "Can't Start Discussion" string + children: app.trans(canStartDiscussion ? 'core.index_start_discussion_button' : 'core.index_cannot_start_discussion_button'), icon: 'edit', className: 'Button Button--primary IndexPage-newDiscussion', itemClassName: 'App-primaryControl', @@ -180,7 +181,7 @@ export default class IndexPage extends Page { items.add('allDiscussions', LinkButton.component({ href: app.route('index', params), - children: app.trans('core.all_discussions'), + children: app.trans('core.index_all_discussions_link'), icon: 'comments-o' }), 100 @@ -201,7 +202,8 @@ export default class IndexPage extends Page { const sortOptions = {}; for (const i in app.cache.discussionList.sortMap()) { - sortOptions[i] = app.trans('core.sort_' + i); + // Core Key Reorganization: Adjusted syntax for new key names + sortOptions[i] = app.trans('core.index_sort_' + i + '_button'); } items.add('sort', @@ -226,7 +228,7 @@ export default class IndexPage extends Page { items.add('refresh', Button.component({ - title: app.trans('core.refresh'), + title: app.trans('core.index_refresh_tooltip'), icon: 'refresh', className: 'Button Button--icon', onclick: () => app.cache.discussionList.refresh() @@ -236,7 +238,7 @@ export default class IndexPage extends Page { if (app.session.user) { items.add('markAllAsRead', Button.component({ - title: app.trans('core.mark_all_as_read'), + title: app.trans('core.index_mark_all_as_read_tooltip'), icon: 'check', className: 'Button Button--icon', onclick: this.markAllAsRead.bind(this) diff --git a/framework/core/js/forum/src/components/LogInModal.js b/framework/core/js/forum/src/components/LogInModal.js index ad2ac1769..a2ee8bad4 100644 --- a/framework/core/js/forum/src/components/LogInModal.js +++ b/framework/core/js/forum/src/components/LogInModal.js @@ -37,7 +37,7 @@ export default class LogInModal extends Modal { } title() { - return app.trans('core.log_in'); + return app.trans('core.log_in_title'); } content() { @@ -47,14 +47,14 @@ export default class LogInModal extends Modal {
    -
    - @@ -65,20 +65,21 @@ export default class LogInModal extends Modal { className: 'Button Button--primary Button--block', type: 'submit', loading: this.loading, - children: app.trans('core.log_in') + children: app.trans('core.log_in_submit_button') })}
    ,

    - {app.trans('core.forgot_password_link')} + {app.trans('core.log_in_forgot_password_link')}

    {app.forum.attribute('allowSignUp') ? (

    - {app.trans('core.before_sign_up_link')}{' '} - {app.trans('core.sign_up')} + // Core Key Reorganization: Moved hardcoded space into preceding string. + {app.trans('core.log_in_no_account_text')} + {app.trans('core.log_in_sign_up_link')}

    ) : ''}
    @@ -131,12 +132,12 @@ export default class LogInModal extends Modal { if (response && response.code === 'confirm_email') { this.alert = Alert.component({ - children: app.trans('core.email_confirmation_required', {email: response.email}) + children: app.trans('core.log_in_confirmation_required_message', {email: response.email}) }); } else { this.alert = Alert.component({ type: 'error', - children: app.trans('core.invalid_login') + children: app.trans('core.log_in_invalid_login_message') }); } diff --git a/framework/core/js/forum/src/components/NotificationGrid.js b/framework/core/js/forum/src/components/NotificationGrid.js index 754674d3a..59e41d897 100644 --- a/framework/core/js/forum/src/components/NotificationGrid.js +++ b/framework/core/js/forum/src/components/NotificationGrid.js @@ -21,8 +21,8 @@ export default class NotificationGrid extends Component { * @type {Array} */ this.methods = [ - {name: 'alert', icon: 'bell', label: app.trans('core.alert')}, - {name: 'email', icon: 'envelope-o', label: app.trans('core.email')} + {name: 'alert', icon: 'bell', label: app.trans('core.settings_notify_by_web_heading')}, + {name: 'email', icon: 'envelope-o', label: app.trans('core.settings_notify_by_email_heading')} ]; /** @@ -182,7 +182,7 @@ export default class NotificationGrid extends Component { items.add('discussionRenamed', { name: 'discussionRenamed', icon: 'pencil', - label: app.trans('core.notify_discussion_renamed') + label: app.trans('core.settings_notify_discussion_renamed_label') }); return items; diff --git a/framework/core/js/forum/src/components/NotificationList.js b/framework/core/js/forum/src/components/NotificationList.js index 0b1b96679..e7732e91a 100644 --- a/framework/core/js/forum/src/components/NotificationList.js +++ b/framework/core/js/forum/src/components/NotificationList.js @@ -59,12 +59,12 @@ export default class NotificationList extends Component { {Button.component({ className: 'Button Button--icon Button--link', icon: 'check', - title: app.trans('core.mark_all_as_read'), + title: app.trans('core.notifications_mark_all_as_read_tooltip'), onclick: this.markAllAsRead.bind(this) })}
    -

    {app.trans('core.notifications')}

    +

    {app.trans('core.notifications_title')}

    @@ -98,7 +98,7 @@ export default class NotificationList extends Component { ); }) : !this.loading - ?
    {app.trans('core.no_notifications')}
    + ?
    {app.trans('core.notifications_empty_text')}
    : LoadingIndicator.component({className: 'LoadingIndicator--block'})}
    diff --git a/framework/core/js/forum/src/components/NotificationsDropdown.js b/framework/core/js/forum/src/components/NotificationsDropdown.js index 68b92b8ff..8e6bacbb2 100644 --- a/framework/core/js/forum/src/components/NotificationsDropdown.js +++ b/framework/core/js/forum/src/components/NotificationsDropdown.js @@ -7,7 +7,7 @@ export default class NotificationsDropdown extends Dropdown { props.className = props.className || 'NotificationsDropdown'; props.buttonClassName = props.buttonClassName || 'Button Button--flat'; props.menuClassName = props.menuClassName || 'Dropdown-menu--right'; - props.label = props.label || app.trans('core.notifications'); + props.label = props.label || app.trans('core.notifications_tooltip'); props.icon = props.icon || 'bell'; super.initProps(props); diff --git a/framework/core/js/forum/src/components/PostEdited.js b/framework/core/js/forum/src/components/PostEdited.js index 4ff04b6fe..c7a1c0b2e 100644 --- a/framework/core/js/forum/src/components/PostEdited.js +++ b/framework/core/js/forum/src/components/PostEdited.js @@ -15,7 +15,7 @@ export default class PostEdited extends Component { view() { const post = this.props.post; const editUser = post.editUser(); - const title = extractText(app.trans('core.post_edited', {user: editUser, ago: humanTime(post.editTime())})); + const title = extractText(app.trans('core.post_edited_tooltip', {user: editUser, ago: humanTime(post.editTime())})); return ( {icon('pencil')} diff --git a/framework/core/js/forum/src/components/PostMeta.js b/framework/core/js/forum/src/components/PostMeta.js index 96d0f267e..dd1909a69 100644 --- a/framework/core/js/forum/src/components/PostMeta.js +++ b/framework/core/js/forum/src/components/PostMeta.js @@ -33,7 +33,7 @@ export default class PostMeta extends Component {
    - {app.trans('core.post_number', {number: post.number()})}{' '} + {app.trans('core.post_number_tooltip', {number: post.number()})}{' '} {fullTime(time)} {touch ? {permalink} diff --git a/framework/core/js/forum/src/components/PostStream.js b/framework/core/js/forum/src/components/PostStream.js index ea0a97a72..86d2d2c31 100644 --- a/framework/core/js/forum/src/components/PostStream.js +++ b/framework/core/js/forum/src/components/PostStream.js @@ -221,7 +221,7 @@ class PostStream extends mixin(Component, evented) { if (dt > 1000 * 60 * 60 * 24 * 4) { content = [
    - {app.trans('core.period_later', {period: moment.duration(dt).humanize()})} + {app.trans('core.post_stream_time_lapsed_text', {period: moment.duration(dt).humanize()})}
    , content ]; diff --git a/framework/core/js/forum/src/components/PostStreamScrubber.js b/framework/core/js/forum/src/components/PostStreamScrubber.js index 66dae0502..471e907d0 100644 --- a/framework/core/js/forum/src/components/PostStreamScrubber.js +++ b/framework/core/js/forum/src/components/PostStreamScrubber.js @@ -71,7 +71,7 @@ export default class PostStreamScrubber extends Component { const unreadCount = this.props.stream.discussion.unreadCount(); const unreadPercent = Math.min(this.count() - this.index, unreadCount) / this.count(); - const viewing = app.trans('core.viewing_posts', { + const viewing = app.trans('core.post_scrubber_viewing_text', { index: {retain || formatNumber(this.visibleIndex())}, count: {formatNumber(this.count())} }); @@ -101,7 +101,7 @@ export default class PostStreamScrubber extends Component {
    - {icon('angle-double-up')} {app.trans('core.original_post')} + {icon('angle-double-up')} {app.trans('core.post_scrubber_original_post_link')}
    @@ -116,12 +116,12 @@ export default class PostStreamScrubber extends Component {
    - {app.trans('core.unread_posts', {count: unreadCount})} + {app.trans('core.post_scrubber_unread_text', {count: unreadCount})}
    - {icon('angle-double-down')} {app.trans('core.now')} + {icon('angle-double-down')} {app.trans('core.post_scrubber_now_link')}
    diff --git a/framework/core/js/forum/src/components/PostsUserPage.js b/framework/core/js/forum/src/components/PostsUserPage.js index d08a3f3e1..8a09534bd 100644 --- a/framework/core/js/forum/src/components/PostsUserPage.js +++ b/framework/core/js/forum/src/components/PostsUserPage.js @@ -51,7 +51,7 @@ export default class PostsUserPage extends UserPage { footer = (
    {Button.component({ - children: app.trans('core.load_more'), + children: app.trans('core.user_posts_load_more_button'), className: 'Button', onclick: this.loadMore.bind(this) })} diff --git a/framework/core/js/forum/src/components/ReplyComposer.js b/framework/core/js/forum/src/components/ReplyComposer.js index 32d96ad60..247467272 100644 --- a/framework/core/js/forum/src/components/ReplyComposer.js +++ b/framework/core/js/forum/src/components/ReplyComposer.js @@ -24,9 +24,9 @@ export default class ReplyComposer extends ComposerBody { static initProps(props) { super.initProps(props); - props.placeholder = props.placeholder || app.trans('core.write_a_reply'); - props.submitLabel = props.submitLabel || app.trans('core.post_reply'); - props.confirmExit = props.confirmExit || app.trans('core.confirm_discard_reply'); + props.placeholder = props.placeholder || app.trans('core.composer_reply_body_placeholder'); + props.submitLabel = props.submitLabel || app.trans('core.composer_reply_submit_button'); + props.confirmExit = props.confirmExit || app.trans('core.composer_reply_discard_confirmation'); } headerItems() { @@ -75,7 +75,7 @@ export default class ReplyComposer extends ComposerBody { let alert; const viewButton = Button.component({ className: 'Button Button--link', - children: app.trans('core.view'), + children: app.trans('core.composer_reply_view_button'), onclick: () => { m.route(app.route.post(post)); app.alerts.dismiss(alert); @@ -84,7 +84,7 @@ export default class ReplyComposer extends ComposerBody { app.alerts.show( alert = new Alert({ type: 'success', - message: app.trans('core.reply_posted'), + message: app.trans('core.composer_reply_posted_message'), controls: [viewButton] }) ); diff --git a/framework/core/js/forum/src/components/ReplyPlaceholder.js b/framework/core/js/forum/src/components/ReplyPlaceholder.js index b5b0c8039..190d3643a 100644 --- a/framework/core/js/forum/src/components/ReplyPlaceholder.js +++ b/framework/core/js/forum/src/components/ReplyPlaceholder.js @@ -44,7 +44,7 @@ export default class ReplyPlaceholder extends Component {
    {avatar(app.session.user, {className: 'PostUser-avatar'})}{' '} - {app.trans('core.write_a_reply')} + {app.trans('core.post_stream_reply_placeholder')}
    ); diff --git a/framework/core/js/forum/src/components/Search.js b/framework/core/js/forum/src/components/Search.js index 93392dbe1..4b836a1bd 100644 --- a/framework/core/js/forum/src/components/Search.js +++ b/framework/core/js/forum/src/components/Search.js @@ -83,7 +83,7 @@ export default class Search extends Component { })}>
    this.hasFocus = true} diff --git a/framework/core/js/forum/src/components/SessionDropdown.js b/framework/core/js/forum/src/components/SessionDropdown.js index a7f8b8b58..a7d0d404d 100644 --- a/framework/core/js/forum/src/components/SessionDropdown.js +++ b/framework/core/js/forum/src/components/SessionDropdown.js @@ -47,7 +47,7 @@ export default class SessionDropdown extends Dropdown { items.add('profile', LinkButton.component({ icon: 'user', - children: app.trans('core.profile'), + children: app.trans('core.header_profile_button'), href: app.route.user(user) }), 100 @@ -56,7 +56,7 @@ export default class SessionDropdown extends Dropdown { items.add('settings', LinkButton.component({ icon: 'cog', - children: app.trans('core.settings'), + children: app.trans('core.header_settings_button'), href: app.route('settings') }), 50 @@ -66,7 +66,7 @@ export default class SessionDropdown extends Dropdown { items.add('administration', LinkButton.component({ icon: 'wrench', - children: app.trans('core.administration'), + children: app.trans('core.header_admin_button'), href: app.forum.attribute('baseUrl') + '/admin', target: '_blank', config: () => {} @@ -80,7 +80,7 @@ export default class SessionDropdown extends Dropdown { items.add('logOut', Button.component({ icon: 'sign-out', - children: app.trans('core.log_out'), + children: app.trans('core.header_log_out_button'), onclick: app.session.logout.bind(app.session) }), -100 diff --git a/framework/core/js/forum/src/components/SettingsPage.js b/framework/core/js/forum/src/components/SettingsPage.js index e2d15b9af..91372cb89 100644 --- a/framework/core/js/forum/src/components/SettingsPage.js +++ b/framework/core/js/forum/src/components/SettingsPage.js @@ -17,7 +17,7 @@ export default class SettingsPage extends UserPage { super(...args); this.show(app.session.user); - app.setTitle(app.trans('core.settings')); + app.setTitle(app.trans('core.settings_title')); } content() { @@ -38,7 +38,7 @@ export default class SettingsPage extends UserPage { items.add('account', FieldSet.component({ - label: app.trans('core.account'), + label: app.trans('core.settings_account_heading'), className: 'Settings-account', children: this.accountItems().toArray() }) @@ -46,7 +46,7 @@ export default class SettingsPage extends UserPage { items.add('notifications', FieldSet.component({ - label: app.trans('core.notifications'), + label: app.trans('core.settings_notifications_heading'), className: 'Settings-notifications', children: [NotificationGrid.component({user: this.user})] }) @@ -54,7 +54,7 @@ export default class SettingsPage extends UserPage { items.add('privacy', FieldSet.component({ - label: app.trans('core.privacy'), + label: app.trans('core.settings_privacy_heading'), className: 'Settings-privacy', children: this.privacyItems().toArray() }) @@ -73,7 +73,7 @@ export default class SettingsPage extends UserPage { items.add('changePassword', Button.component({ - children: app.trans('core.change_password'), + children: app.trans('core.settings_change_password_button'), className: 'Button', onclick: () => app.modal.show(new ChangePasswordModal()) }) @@ -81,7 +81,7 @@ export default class SettingsPage extends UserPage { items.add('changeEmail', Button.component({ - children: app.trans('core.change_email'), + children: app.trans('core.settings_change_email_button'), className: 'Button', onclick: () => app.modal.show(new ChangeEmailModal()) }) @@ -118,7 +118,7 @@ export default class SettingsPage extends UserPage { items.add('discloseOnline', Switch.component({ - children: app.trans('core.disclose_online'), + children: app.trans('core.settings_privacy_disclose_online_label'), state: this.user.preferences().discloseOnline, onchange: (value, component) => { this.user.pushAttributes({lastSeenTime: null}); diff --git a/framework/core/js/forum/src/components/SignUpModal.js b/framework/core/js/forum/src/components/SignUpModal.js index 19899560e..89e84b390 100644 --- a/framework/core/js/forum/src/components/SignUpModal.js +++ b/framework/core/js/forum/src/components/SignUpModal.js @@ -52,7 +52,7 @@ export default class SignUpModal extends Modal { } title() { - return app.trans('core.sign_up'); + return app.trans('core.sign_up_title'); } content() { @@ -72,14 +72,14 @@ export default class SignUpModal extends Modal {
    -
    - @@ -87,7 +87,7 @@ export default class SignUpModal extends Modal { {this.props.token ? '' : (
    - @@ -99,7 +99,7 @@ export default class SignUpModal extends Modal { className="Button Button--primary Button--block" type="submit" loading={this.loading}> - {app.trans('core.sign_up')} + {app.trans('core.sign_up_submit_button')}
    @@ -119,13 +119,14 @@ export default class SignUpModal extends Modal {
    {avatar(user)} -

    {app.trans('core.welcome_user', {user})}

    +

    {app.trans('core.sign_up_welcome_text', {user})}

    -

    {app.trans('core.confirmation_email_sent', {email: {user.email()}})}

    +

    {app.trans('core.sign_up_confirmation_message', {email: {user.email()}})}

    + // Core Key Reorganization: This needs to be changed to a dismiss button! - {app.trans('core.go_to', {location: emailProviderName})} + {app.trans('core.sign_up_dismiss_button', {location: emailProviderName})}

    @@ -140,8 +141,9 @@ export default class SignUpModal extends Modal { footer() { return [

    - {app.trans('core.before_log_in_link')}{' '} - {app.trans('core.log_in')} + // Core Key Reorganization: Moved hardcoded space into preceding string. + {app.trans('core.sign_up_already_have_account_text')} + {app.trans('core.sign_up_log_in_link')}

    ]; } diff --git a/framework/core/js/forum/src/components/TerminalPost.js b/framework/core/js/forum/src/components/TerminalPost.js index c7125104e..31bca336d 100644 --- a/framework/core/js/forum/src/components/TerminalPost.js +++ b/framework/core/js/forum/src/components/TerminalPost.js @@ -19,7 +19,8 @@ export default class TerminalPost extends Component { return ( - {app.trans('core.discussion_' + (lastPost ? 'replied' : 'started'), { + // Core Key Reorganization: Adjusted syntax for new key names + {app.trans('core.discussion_list_' + (lastPost ? 'replied' : 'started') + '_text', { user, ago: humanTime(time) })} diff --git a/framework/core/js/forum/src/components/UserBio.js b/framework/core/js/forum/src/components/UserBio.js index 20e18d5c7..cba926f23 100644 --- a/framework/core/js/forum/src/components/UserBio.js +++ b/framework/core/js/forum/src/components/UserBio.js @@ -30,7 +30,7 @@ export default class UserBio extends Component { let content; if (this.editing) { - content =