From 77062dd833ac35880aca703077ae588dfff2b32d Mon Sep 17 00:00:00 2001 From: Matt Kilgore Date: Tue, 17 Mar 2020 17:37:17 -0400 Subject: [PATCH] Change Extenders properties to private (#1958) --- framework/core/src/Extend/Compat.php | 2 +- framework/core/src/Extend/Formatter.php | 2 +- framework/core/src/Extend/Frontend.php | 10 +++++----- framework/core/src/Extend/Locales.php | 2 +- framework/core/src/Extend/Middleware.php | 12 ++++++------ framework/core/src/Extend/Routes.php | 4 ++-- 6 files changed, 16 insertions(+), 16 deletions(-) diff --git a/framework/core/src/Extend/Compat.php b/framework/core/src/Extend/Compat.php index 1cfb2146f..e99b483e7 100644 --- a/framework/core/src/Extend/Compat.php +++ b/framework/core/src/Extend/Compat.php @@ -23,7 +23,7 @@ use Illuminate\Contracts\Container\Container; */ class Compat implements ExtenderInterface { - protected $callback; + private $callback; public function __construct($callback) { diff --git a/framework/core/src/Extend/Formatter.php b/framework/core/src/Extend/Formatter.php index 889772b7e..b185a12cd 100644 --- a/framework/core/src/Extend/Formatter.php +++ b/framework/core/src/Extend/Formatter.php @@ -17,7 +17,7 @@ use Illuminate\Events\Dispatcher; class Formatter implements ExtenderInterface, LifecycleInterface { - protected $callback; + private $callback; public function configure($callback) { diff --git a/framework/core/src/Extend/Frontend.php b/framework/core/src/Extend/Frontend.php index 9f7129101..3fd5e8554 100644 --- a/framework/core/src/Extend/Frontend.php +++ b/framework/core/src/Extend/Frontend.php @@ -25,12 +25,12 @@ use Illuminate\Contracts\Container\Container; class Frontend implements ExtenderInterface { - protected $frontend; + private $frontend; - protected $css = []; - protected $js; - protected $routes = []; - protected $content = []; + private $css = []; + private $js; + private $routes = []; + private $content = []; public function __construct(string $frontend) { diff --git a/framework/core/src/Extend/Locales.php b/framework/core/src/Extend/Locales.php index 8c6fd5f7f..533416144 100644 --- a/framework/core/src/Extend/Locales.php +++ b/framework/core/src/Extend/Locales.php @@ -16,7 +16,7 @@ use Illuminate\Contracts\Container\Container; class Locales implements ExtenderInterface, LifecycleInterface { - protected $directory; + private $directory; public function __construct($directory) { diff --git a/framework/core/src/Extend/Middleware.php b/framework/core/src/Extend/Middleware.php index 73e0d2d5e..fac40bd56 100644 --- a/framework/core/src/Extend/Middleware.php +++ b/framework/core/src/Extend/Middleware.php @@ -14,12 +14,12 @@ use Illuminate\Contracts\Container\Container; class Middleware implements ExtenderInterface { - protected $addMiddlewares = []; - protected $removeMiddlewares = []; - protected $replaceMiddlewares = []; - protected $insertBeforeMiddlewares = []; - protected $insertAfterMiddlewares = []; - protected $frontend; + private $addMiddlewares = []; + private $removeMiddlewares = []; + private $replaceMiddlewares = []; + private $insertBeforeMiddlewares = []; + private $insertAfterMiddlewares = []; + private $frontend; public function __construct(string $frontend) { diff --git a/framework/core/src/Extend/Routes.php b/framework/core/src/Extend/Routes.php index 3867ca541..33e1e4da3 100644 --- a/framework/core/src/Extend/Routes.php +++ b/framework/core/src/Extend/Routes.php @@ -16,9 +16,9 @@ use Illuminate\Contracts\Container\Container; class Routes implements ExtenderInterface { - protected $appName; + private $appName; - protected $routes = []; + private $routes = []; public function __construct($appName) {