From 827c8ff50f6db092a470063e7651a05138f17e3f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Sevilla=20Mart=C3=ADn?= <6401250+datitisev@users.noreply.github.com> Date: Mon, 9 Sep 2019 17:05:11 -0400 Subject: [PATCH] Fix error thrown if textarea doesn't exist in TextEditor (#1852) * Prevent textarea not existing from causing errors to be thrown * Replace [0] with .length --- framework/core/js/src/forum/components/TextEditor.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/framework/core/js/src/forum/components/TextEditor.js b/framework/core/js/src/forum/components/TextEditor.js index c30ca4d20..fbf424b8d 100644 --- a/framework/core/js/src/forum/components/TextEditor.js +++ b/framework/core/js/src/forum/components/TextEditor.js @@ -122,6 +122,8 @@ export default class TextEditor extends Component { setSelectionRange(start, end) { const $textarea = this.$('textarea'); + if (!$textarea.length) return; + $textarea[0].setSelectionRange(start, end); $textarea.focus(); } @@ -134,6 +136,8 @@ export default class TextEditor extends Component { getSelectionRange() { const $textarea = this.$('textarea'); + if (!$textarea.length) return [0, 0]; + return [$textarea[0].selectionStart, $textarea[0].selectionEnd]; }